Skip to content

fix dead and unknown pools logging #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teatou merged 1 commit into from
Feb 27, 2026
Merged

fix dead and unknown pools logging #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions dead_pool_reaper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,14 +146,14 @@ func (r *deadPoolReaper) reap() (err error) {

deadPools, rErr := r.reapDeadPools()
if jobs := deadPools.getAllJobs(); len(jobs) != 0 {
r.logger.Info("Reaper: dead pools", slog.Any("dead", deadPools))
r.logger.Info("Reaper: dead pools", slog.Any("dead", deadPools.toPoolInfo()))

reapResult.NoPoolHeartBeatJobs = jobs
}

unknownPools, cErr := r.clearUnknownPools()
if jobs := unknownPools.getAllJobs(); len(jobs) != 0 {
r.logger.Info("Reaper: unknown pools", slog.Any("unknown", unknownPools))
r.logger.Info("Reaper: unknown pools", slog.Any("unknown", unknownPools.toPoolInfo()))

reapResult.UnknownPoolJobs = jobs
}
Expand Down Expand Up @@ -449,3 +449,20 @@ func (p poolsJobs) getAllJobs() []string {

return r
}

type poolInfo struct {
PoolID string `json:"pool_id"`
Jobs []string `json:"jobs"`
}

func (p poolsJobs) toPoolInfo() []poolInfo {
poolsList := make([]poolInfo, 0, len(p))
for poolID, jobs := range p {
poolsList = append(poolsList, poolInfo{
PoolID: poolID,
Jobs: jobs,
})
}

return poolsList
}