Updates when using recent protobuf versions (here 27.3)

[TommyDMc]

Recent protobuf builds (I'm using 27.3) don't work with this library. But they can. I needed to make a src/CMakeLists.txt update and update a few items in the src/MessageFactory.h file (removed 2 overrides and implemented a pure virtual in ErrorPrinter).

Do you want a diff so someone at KX can fix as you see fit? Happy to help.

-Tom

[nmcdonnell-kx]

Sure, send it over (you can submit a PR) and I'll have a look
My one concern would be backwards compatibility with earlier protobuf versions

[TommyDMc]

I'm happy to do the tests against a goodly number, myriad prior releases. Sorry for the poor english. I've been using protobuf for probably 2 decades, autotools, cmake, bazel...I'll make sure they work. I get google's infatuation w/ Abseil and Bazel. Shudder...I mean static linking, LTO, PGO, BOLT'ing are fantastic perf gains, but sometimes KISS is good enough.

…

-Tom (in Danish, that means 'empty') ps - you guys BOLT the KDB/Q engine? Cats and curiosity, you know.

On Fri, Jan 3, 2025 at 5:07 AM nmcdonnell-kx ***@***.***> wrote: Sure, send it over and I'll have a look My one concern would be backwards compatibility with earlier protobuf versions — Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGWYT5WBVV5JGVQNL5UM35T2IZOPBAVCNFSM6AAAAABT7OK2DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYHE4DANZRGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>