Implement SetHTTPRequestRawPostBodyFromFile#24
Merged
KyleSanderson merged 5 commits intoKyleSanderson:masterfrom Sep 2, 2018
Sikarii:master
Merged
Implement SetHTTPRequestRawPostBodyFromFile#24KyleSanderson merged 5 commits intoKyleSanderson:masterfrom Sikarii:master
KyleSanderson merged 5 commits intoKyleSanderson:masterfrom
Sikarii:master
Conversation
Implement SetHTTPRequestRawPostBodyFromFile
Headline
reviewed
Aug 10, 2018
Extension/swhttprequest.cpp
Outdated
| } | ||
|
|
||
| char *pBuffer = new char[size + 1]; | ||
| fread(pBuffer, sizeof(char), size, pInputFile); |
There was a problem hiding this comment.
not sure if this is ignored in other places throughout the codebase, but fread’s retval should probably be checked to ensure a read didn’t fail.
Made sure that retval of fread() matches filesize
Headline
approved these changes
Aug 10, 2018
Owner
|
Thank you for your contribution. |
maximee-leroyy
pushed a commit
to srcdslab/sm-ext-SteamWorks
that referenced
this pull request
Aug 15, 2022
* Implement SetHTTPRequestRawPostBodyFromFile * Made sure that retval of fread() matches filesize * Minor code cleanup * Moved sm_SetHTTPRequestRawPostBodyFromFile to its appropriate place in the file * style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.