Conversation
Runs Lint only on Ubuntu, saving minutes. Uses a consistent cache. Runs security-audits bi-weekly.
Use binary of cargo audit instead of compiling from source
|
Bencher Report| Branch | update-ci |
| Testbed | mhovd-pgx |
Click to view all benchmark results
| Benchmark | Latency | milliseconds (ms) |
|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 4,962.80 ms |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 1,303.50 ms |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 345.79 ms |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to reduce CI compute and standardize parts of the Rust CI pipeline, including scheduling dependency security audits.
Changes:
- Splits formatting into a dedicated Ubuntu-only
lintjob and gates the test matrix on it. - Replaces manual Cargo caching with
Swatinem/rust-cache@v2in the Rust build/test workflow. - Moves security auditing to
rustsec/audit-check@v2and adds a twice-monthly scheduled run.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/security_audit.yml |
Adds a cron schedule and switches the audit implementation to rustsec/audit-check@v2. |
.github/workflows/rust.yml |
Adds a lint job for cargo fmt, updates caching to rust-cache, and reorganizes the job flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| name: Build | ||
| 'on': | ||
| "on": |
There was a problem hiding this comment.
Workflow trigger key is changed to "on" (quoted) here, but other workflows in this repo still use the unquoted on: form (e.g., .github/workflows/docs.yml, release.yml). Consider keeping the style consistent across workflows (either update the others in the same PR, or revert to on: here).
| "on": | |
| on: |
| name: Security Audit | ||
|
|
||
| 'on': | ||
| "on": |
There was a problem hiding this comment.
Workflow trigger key is quoted as "on" here, while other workflows in the repo use on: unquoted. For consistency/maintainability, consider standardizing on one style across all workflow files.
| "on": | |
| on: |
Attempts to save compute time.
Runs
cargo fmtonly on Ubuntu, and before all other checks.Uses a consistent cache strategy.
Runs security-audits bi-weekly.