Skip to content

fix: Update examples to match the data#259

Merged
mhovd merged 2 commits into
mainfrom
fix/examples
Apr 1, 2026
Merged

fix: Update examples to match the data#259
mhovd merged 2 commits into
mainfrom
fix/examples

Conversation

@Siel
Copy link
Copy Markdown
Member

@Siel Siel commented Mar 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 25, 2026 11:14
@mhovd mhovd changed the title fix examples to match the data fix: Update examples to match the data Mar 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2026

🐰 Bencher Report

Branchfix/examples
Testbedmhovd-pgx
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
4,815.00 ms
(-2.54%)Baseline: 4,940.55 ms
5,168.07 ms
(93.17%)
bimodal_ke_npod📈 view plot
🚷 view threshold
1,453.20 ms
(+3.35%)Baseline: 1,406.10 ms
3,865.83 ms
(37.59%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
280.12 ms
(-34.53%)Baseline: 427.85 ms
1,862.47 ms
(15.04%)
🐰 View full continuous benchmarking report in Bencher

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates example models so their compartment/input/output indexing matches the associated Pmetrics CSV data conventions (notably INPUT/OUTEQ values starting at 1 in these datasets).

Changes:

  • Align dosing/input indexing by switching b[...] / rateiv[...] references from 0 to 1 where INPUT=1 in the CSVs.
  • Align output equation indexing by switching y[...] assignments to match OUTEQ values in the CSVs (e.g., 1..3).
  • Update assay error model registrations to use the same OUTEQ indices as the datasets.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/two_eq_lag/main.rs Shift dose/lag/output/error-model indices to match INPUT=1 and OUTEQ=1 in two_eq_lag.csv.
examples/neely/main.rs Update infusion/dose input index and map outputs + error models to OUTEQ=1..3 in data.csv.
examples/meta/main.rs Update infusion/dose input index and map outputs + error models to OUTEQ=1..2 in meta.csv.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mhovd mhovd merged commit fa83cb5 into main Apr 1, 2026
6 checks passed
@mhovd mhovd deleted the fix/examples branch April 1, 2026 18:40
@github-actions github-actions Bot mentioned this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants