fix: Update examples to match the data#259
Merged
Merged
Conversation
mhovd
approved these changes
Mar 25, 2026
Contributor
|
| Branch | fix/examples |
| Testbed | mhovd-pgx |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 4,815.00 ms(-2.54%)Baseline: 4,940.55 ms | 5,168.07 ms (93.17%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 1,453.20 ms(+3.35%)Baseline: 1,406.10 ms | 3,865.83 ms (37.59%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 280.12 ms(-34.53%)Baseline: 427.85 ms | 1,862.47 ms (15.04%) |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates example models so their compartment/input/output indexing matches the associated Pmetrics CSV data conventions (notably INPUT/OUTEQ values starting at 1 in these datasets).
Changes:
- Align dosing/input indexing by switching
b[...]/rateiv[...]references from0to1whereINPUT=1in the CSVs. - Align output equation indexing by switching
y[...]assignments to matchOUTEQvalues in the CSVs (e.g.,1..3). - Update assay error model registrations to use the same
OUTEQindices as the datasets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/two_eq_lag/main.rs | Shift dose/lag/output/error-model indices to match INPUT=1 and OUTEQ=1 in two_eq_lag.csv. |
| examples/neely/main.rs | Update infusion/dose input index and map outputs + error models to OUTEQ=1..3 in data.csv. |
| examples/meta/main.rs | Update infusion/dose input index and map outputs + error models to OUTEQ=1..2 in meta.csv. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.