feat: Bump pharmsol and update examples#269
Merged
Merged
Conversation
Cache is now enabled by default, so reducing verbosity
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pharmsol dependency and simplifies tests/examples/benches by removing explicit cache enabling now that caching is enabled by default upstream.
Changes:
- Bump
pharmsolfrom=0.25to=0.26. - Remove
.with_default_cache()calls across tests, examples, and benches to reduce verbosity. - Keep model/equation construction semantics the same while relying on new defaults.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps pharmsol to =0.26. |
| tests/onecomp.rs | Removes explicit .with_default_cache() from ODE setup in tests. |
| tests/bestdose_tests.rs | Removes explicit .with_default_cache() in multiple test ODE builders and a shared helper model. |
| benches/bimodal_ke.rs | Removes explicit .with_default_cache() from benchmark ODE setup. |
| examples/vanco.rs | Removes explicit .with_default_cache() from example equation. |
| examples/vanco_sde/main.rs | Removes explicit .with_default_cache() from SDE setup. |
| examples/two_eq_lag/main.rs | Removes explicit .with_default_cache() from example equation. |
| examples/theophylline/main.rs | Removes explicit .with_default_cache() from example ODE setup. |
| examples/new_iov/main.rs | Removes explicit .with_default_cache() from SDE builder chain. |
| examples/neely/main.rs | Removes explicit .with_default_cache() from example equation. |
| examples/meta/main.rs | Removes explicit .with_default_cache() from example equation. |
| examples/iov/main.rs | Removes explicit .with_default_cache() from SDE builder chain. |
| examples/drusano/main.rs | Removes explicit .with_default_cache() from example equation. |
| examples/bimodal_ke/main.rs | Removes explicit .with_default_cache() from example equation builder chain. |
| examples/bestdose.rs | Removes explicit .with_default_cache() from example equation. |
| examples/bestdose_bounds.rs | Removes explicit .with_default_cache() from example equation. |
| examples/bestdose_auc.rs | Removes explicit .with_default_cache() from example equation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
| Branch | pharmsol-0.26 |
| Testbed | mhovd-pgx |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 4,797.70 ms(-1.87%)Baseline: 4,889.18 ms | 5,063.46 ms (94.75%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 1,268.10 ms(-9.92%)Baseline: 1,407.78 ms | 1,624.76 ms (78.05%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 58.03 ms(-84.47%)Baseline: 373.61 ms | 685.28 ms (8.47%) |
Siel
approved these changes
Apr 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache is now enabled by default, so reducing verbosity