Skip to content

feat: Bump pharmsol and update examples#269

Merged
mhovd merged 1 commit into
mainfrom
pharmsol-0.26
Apr 11, 2026
Merged

feat: Bump pharmsol and update examples#269
mhovd merged 1 commit into
mainfrom
pharmsol-0.26

Conversation

@mhovd
Copy link
Copy Markdown
Collaborator

@mhovd mhovd commented Apr 11, 2026

Cache is now enabled by default, so reducing verbosity

Cache is now enabled by default, so reducing verbosity
Copilot AI review requested due to automatic review settings April 11, 2026 07:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pharmsol dependency and simplifies tests/examples/benches by removing explicit cache enabling now that caching is enabled by default upstream.

Changes:

  • Bump pharmsol from =0.25 to =0.26.
  • Remove .with_default_cache() calls across tests, examples, and benches to reduce verbosity.
  • Keep model/equation construction semantics the same while relying on new defaults.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Bumps pharmsol to =0.26.
tests/onecomp.rs Removes explicit .with_default_cache() from ODE setup in tests.
tests/bestdose_tests.rs Removes explicit .with_default_cache() in multiple test ODE builders and a shared helper model.
benches/bimodal_ke.rs Removes explicit .with_default_cache() from benchmark ODE setup.
examples/vanco.rs Removes explicit .with_default_cache() from example equation.
examples/vanco_sde/main.rs Removes explicit .with_default_cache() from SDE setup.
examples/two_eq_lag/main.rs Removes explicit .with_default_cache() from example equation.
examples/theophylline/main.rs Removes explicit .with_default_cache() from example ODE setup.
examples/new_iov/main.rs Removes explicit .with_default_cache() from SDE builder chain.
examples/neely/main.rs Removes explicit .with_default_cache() from example equation.
examples/meta/main.rs Removes explicit .with_default_cache() from example equation.
examples/iov/main.rs Removes explicit .with_default_cache() from SDE builder chain.
examples/drusano/main.rs Removes explicit .with_default_cache() from example equation.
examples/bimodal_ke/main.rs Removes explicit .with_default_cache() from example equation builder chain.
examples/bestdose.rs Removes explicit .with_default_cache() from example equation.
examples/bestdose_bounds.rs Removes explicit .with_default_cache() from example equation.
examples/bestdose_auc.rs Removes explicit .with_default_cache() from example equation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchpharmsol-0.26
Testbedmhovd-pgx
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
bimodal_ke_npag📈 view plot
🚷 view threshold
4,797.70 ms
(-1.87%)Baseline: 4,889.18 ms
5,063.46 ms
(94.75%)
bimodal_ke_npod📈 view plot
🚷 view threshold
1,268.10 ms
(-9.92%)Baseline: 1,407.78 ms
1,624.76 ms
(78.05%)
bimodal_ke_postprob📈 view plot
🚷 view threshold
58.03 ms
(-84.47%)Baseline: 373.61 ms
685.28 ms
(8.47%)
🐰 View full continuous benchmarking report in Bencher

@mhovd mhovd merged commit 40af27f into main Apr 11, 2026
11 checks passed
@github-actions github-actions Bot mentioned this pull request Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants