This repository was archived by the owner on Nov 5, 2020. It is now read-only.
G92 4-axis fix and Mac/Linux build error#1
Merged
LETARTARE merged 2 commits intoLETARTARE:Letartarefrom Nov 3, 2014
Merged
Conversation
When clicking on the zero-axes button (to the right of the Home button), a G92 command of the form G92 x0 y0 z0 a would be incorrectly emitted. This change moves the toLower() method so that it is called on the QString instance of the axis name attribute directly rather than on the result of the append() method.
Replaced backslash with POSIX-style slash for directory separator in include.
LETARTARE
added a commit
that referenced
this pull request
Nov 3, 2014
G92 4-axis fix and Mac/Linux build error
Owner
|
@srichy |
Author
|
I've committed a Linux fix to my repo and will create a new pull request for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced backslash with POSIX-style slash for directory separator in include.
G92 T axis value missing offset in 4-axis mode in GCV
When clicking on the zero-axes button (to the right of the Home
button), a G92 command of the form
G92 x0 y0 z0 a
would be incorrectly emitted. This change moves the toLower() method
so that it is called on the QString instance of the axis name
attribute directly rather than on the result of the append() method.