Query by child value #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhvl-Golakiya please review and test this on both iOS and Android and merge if everything works fine. |
Author
|
FYI, I was finally able to test on Android and it works great |
| } | ||
| } | ||
|
|
||
| internal class ReadByQueryEqualToValue : Promise<string> |
There was a problem hiding this comment.
You have to declare this class as extern(!mobile) We are getting an error in Mobile build with a duplicate declaration.
src/Firebase.Database/Database.uno
Outdated
| internal class ReadByQueryEqualToValue : Promise<string> | ||
| { | ||
| [Foreign(Language.Java)] | ||
| public ReadByQueryEqualToValue(string path) |
There was a problem hiding this comment.
Need three parameters path, 'key and val for this function.
Dhvl-Golakiya
added
enhancement
changes-requested
and removed
to-review-by-dhaval
enhancement
labels
I do not know what I was thinking, I have two FuseFirebase repos, must have missed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation, works great on iOS. Sadly can't test on Android but should work