Daemon does not use port parameter #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
approved these changes
Sep 18, 2022
Contributor
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
ACK https://github.com/LNP-WG/lnp-node/pull/59/files
Thanks for the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
peerddaemon uses only the default port instead of the port number parameter.Steps to Reproduce
lnpdwithout --threaded argument.lnp-cli listenwith --port argument.**Expected: ** The
lnpdlaunchpeerdwith defined port argument.**Current: ** the
microservice::supervisortry spawnpeerdwith port 9999 and causes rust panic (Unable to bind to Lightning network peer socket: Os { code: 98, kind: AddrInUse, message: "Address already in use" })This PR fixies this.