IMC.xml: adds HealthCheck msg#35
Merged
paulosousadias merged 1 commit intoLSTS:feature/unifyfrom Mar 8, 2023
Merged
Conversation
Member
|
Can't this: <field name="Entity Name" abbrev="entity_name" type="plaintext">
<description>Entity Label of the task that's replying to the request</description>
</field>be <field name="Entity Name" abbrev="entity_name" type="plaintext">
<description>Entity label of the request/reply</description>
</field>This is because evem in the request this will be filled, right? |
Author
|
In our case we use the destination entity from the header to make requests to a specific sensor. If we want to request self-testing on all sensors we put the destination entity to 255. |
Member
|
Ok, but then this is what? if you use the header, the response header will also identify the responding entity, so what is the point of this field. We can always get the name of an entity in the EntityList |
Author
|
With this field you are not dependent on querying the EntityList. You can send an initial HealthCheck with OP=Query and dstEnt = 255 and receive the entity ids and names of all tasks that implement the HealthCheck protocol. |
Member
|
But that is why EntityList. exists, so we don't need to add the label on every msgs we need the label of an entity. |
Author
|
It's a balance between protocol simplification vs a few bytes of memory. It's not a message that is sent periodically, so having an extra field is not as relevant as in other messages. |
Member
|
Olá,
Existem várias outras mensagens (relacionadas com esta) que seguem a mesma
aproximação:
<message id="803" name="QueryEntityParameters"
abbrev="QueryEntityParameters" source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
<field name="Visibility" abbrev="visibility" type="plaintext"/>
<field name="Scope" abbrev="scope" type="plaintext"/>
</message>
<message id="804" name="SetEntityParameters" abbrev="SetEntityParameters"
source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
<field name="Parameters" abbrev="params" type="message-list"
message-type="EntityParameter"/>
</message>
<message id="805" name="SaveEntityParameters"
abbrev="SaveEntityParameters" source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
</message>
Abraço,
ZP
…On Fri, Mar 3, 2023 at 3:08 PM Renato Campos ***@***.***> wrote:
It's a balance between protocol simplification vs a few bytes of memory.
It's not a message that is sent periodically, so having an extra field is
not as relevant as in other messages.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL5LGIIEYEUUN4POWZDWHLW2ICOLANCNFSM6AAAAAAVNTMRTI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Member
|
Viva Zé,
Neste caso as msg são enviadas para o deamon e não para as tasks, ou seja
são enviadas para 255. Neste caso o Renato está a dirigir a query para a
task, pelo q ele disse. Se tens q direcionar para a task, tens o campo
duplicado. É assim?
Ab,
Paulo
Jose Pinto ***@***.***> escreveu no dia segunda, 6/03/2023
à(s) 10:49:
… Olá,
Existem várias outras mensagens (relacionadas com esta) que seguem a mesma
aproximação:
<message id="803" name="QueryEntityParameters"
abbrev="QueryEntityParameters" source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
<field name="Visibility" abbrev="visibility" type="plaintext"/>
<field name="Scope" abbrev="scope" type="plaintext"/>
</message>
<message id="804" name="SetEntityParameters" abbrev="SetEntityParameters"
source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
<field name="Parameters" abbrev="params" type="message-list"
message-type="EntityParameter"/>
</message>
<message id="805" name="SaveEntityParameters"
abbrev="SaveEntityParameters" source="ccu,vehicle" category="Core">
<field name="Entity Name" abbrev="name" type="plaintext"/>
</message>
Abraço,
ZP
On Fri, Mar 3, 2023 at 3:08 PM Renato Campos ***@***.***>
wrote:
> It's a balance between protocol simplification vs a few bytes of memory.
> It's not a message that is sent periodically, so having an extra field is
> not as relevant as in other messages.
>
> —
> Reply to this email directly, view it on GitHub
> <#35 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAL5LGIIEYEUUN4POWZDWHLW2ICOLANCNFSM6AAAAAAVNTMRTI
>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4GO6PGLP7MTH6XPOODNNTW2W6MNANCNFSM6AAAAAAVNTMRTI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
Se direcionares para a task podes nem preencher o name, da mesma forma que
fazes se for para id=255.
A vantagem é que fica em log a tarefa, nome e estado de verificação, numa
só mensagem (simplifica a geração de relatórios que não dependem assim de
outras mensagens).
Isto não são mensagens periódicas pelo que não vejo grande ganho em não se
repetir essa informação (da mesma forma que se repite nas mensagens que
indiquei).
PS: a implementação já está feita do nosso lado.
A terça, 7/03/2023, 12:23, Paulo Dias ***@***.***> escreveu:
… Viva Zé,
Neste caso as msg são enviadas para o deamon e não para as tasks, ou seja
são enviadas para 255. Neste caso o Renato está a dirigir a query para a
task, pelo q ele disse. Se tens q direcionar para a task, tens o campo
duplicado. É assim?
Ab,
Paulo
Jose Pinto ***@***.***> escreveu no dia segunda, 6/03/2023
à(s) 10:49:
> Olá,
>
> Existem várias outras mensagens (relacionadas com esta) que seguem a
mesma
> aproximação:
>
> <message id="803" name="QueryEntityParameters"
> abbrev="QueryEntityParameters" source="ccu,vehicle" category="Core">
> <field name="Entity Name" abbrev="name" type="plaintext"/>
> <field name="Visibility" abbrev="visibility" type="plaintext"/>
> <field name="Scope" abbrev="scope" type="plaintext"/>
> </message>
>
> <message id="804" name="SetEntityParameters" abbrev="SetEntityParameters"
> source="ccu,vehicle" category="Core">
> <field name="Entity Name" abbrev="name" type="plaintext"/>
> <field name="Parameters" abbrev="params" type="message-list"
> message-type="EntityParameter"/>
> </message>
>
> <message id="805" name="SaveEntityParameters"
> abbrev="SaveEntityParameters" source="ccu,vehicle" category="Core">
> <field name="Entity Name" abbrev="name" type="plaintext"/>
> </message>
>
> Abraço,
> ZP
>
> On Fri, Mar 3, 2023 at 3:08 PM Renato Campos ***@***.***>
> wrote:
>
> > It's a balance between protocol simplification vs a few bytes of
memory.
> > It's not a message that is sent periodically, so having an extra field
is
> > not as relevant as in other messages.
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <#35 (comment)>, or
> > unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAL5LGIIEYEUUN4POWZDWHLW2ICOLANCNFSM6AAAAAAVNTMRTI
> >
> > .
> > You are receiving this because you are subscribed to this
thread.Message
> > ID: ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <#35 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AA4GO6PGLP7MTH6XPOODNNTW2W6MNANCNFSM6AAAAAAVNTMRTI
>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#35 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL5LGLIOSKMMIG3SNBI533W24SE3ANCNFSM6AAAAAAVNTMRTI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HealthCheck message is part of new developments at OceanScan for self-testing of payload and sensors.