Copier Update (better compatibility with Apple Silicon)#32
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Warning Rate limit exceeded@ejfine has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
Updates the project template to improve compatibility with Apple Silicon Macs by adding explicit platform specification for Docker containers and updating various configuration files.
- Added platform specification for devcontainer to force Linux/amd64 compatibility
- Updated file paths to use workspace variables instead of hardcoded paths
- Updated template version and excluded additional generated files from linting
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Excludes generated GraphQL TypeScript files from pre-commit checks |
.devcontainer/docker-compose.yml |
Adds platform specification to ensure Linux/amd64 compatibility |
.devcontainer/devcontainer.json |
Updates Ruff configuration path and devcontainer hash |
.copier-answers.yml |
Updates template commit reference to newer version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,5 +1,7 @@ | |||
| services: | |||
| devcontainer: | |||
| # added the platform flag to override any local settings since this image is only compatible with linux/amd64. | |||
There was a problem hiding this comment.
The comment should start with a capital letter: 'Added the platform flag...' instead of 'added the platform flag...'
| # added the platform flag to override any local settings since this image is only compatible with linux/amd64. | |
| # Added the platform flag to override any local settings since this image is only compatible with linux/amd64. |
|
@photocyte - it seems your changes result in Codespaces and devcontainers-on-a-windows-devevelopment-machine working just fine (in my hands at least), so they can definitely be incorporated. Because those changes you proposed would universally help Mac developers across all projects in the https://github.com/LabAutomationAndScreening ecosystem, I updated the template repositories that this repository uses, and then used Let me know if you see anything missing in this PR that was in yours. If not, then I'll merge this one in, and then any future repositories created with those templates will automatically be more Mac-developer friendly thanks to your suggestions |
Addressing the issue raised in #30 by pulling in upstream template changes from LabAutomationAndScreening/copier-base-template#80 and LabAutomationAndScreening/copier-python-package-template#59