Skip to content

Copier Update (better compatibility with Apple Silicon)#32

Merged
ejfine merged 2 commits intomainfrom
copier-mac
Aug 14, 2025
Merged

Copier Update (better compatibility with Apple Silicon)#32
ejfine merged 2 commits intomainfrom
copier-mac

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Aug 14, 2025

Addressing the issue raised in #30 by pulling in upstream template changes from LabAutomationAndScreening/copier-base-template#80 and LabAutomationAndScreening/copier-python-package-template#59

@ejfine ejfine requested a review from Copilot August 14, 2025 18:50
@ejfine ejfine self-assigned this Aug 14, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 14, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Warning

Rate limit exceeded

@ejfine has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9927ce9 and 1a52c96.

📒 Files selected for processing (5)
  • .copier-answers.yml (1 hunks)
  • .devcontainer/devcontainer.json (2 hunks)
  • .devcontainer/docker-compose.yml (1 hunks)
  • .gitignore (1 hunks)
  • .pre-commit-config.yaml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch copier-mac

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the project template to improve compatibility with Apple Silicon Macs by adding explicit platform specification for Docker containers and updating various configuration files.

  • Added platform specification for devcontainer to force Linux/amd64 compatibility
  • Updated file paths to use workspace variables instead of hardcoded paths
  • Updated template version and excluded additional generated files from linting

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
.pre-commit-config.yaml Excludes generated GraphQL TypeScript files from pre-commit checks
.devcontainer/docker-compose.yml Adds platform specification to ensure Linux/amd64 compatibility
.devcontainer/devcontainer.json Updates Ruff configuration path and devcontainer hash
.copier-answers.yml Updates template commit reference to newer version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -1,5 +1,7 @@
services:
devcontainer:
# added the platform flag to override any local settings since this image is only compatible with linux/amd64.
Copy link

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should start with a capital letter: 'Added the platform flag...' instead of 'added the platform flag...'

Suggested change
# added the platform flag to override any local settings since this image is only compatible with linux/amd64.
# Added the platform flag to override any local settings since this image is only compatible with linux/amd64.

Copilot uses AI. Check for mistakes.
@ejfine
Copy link
Contributor Author

ejfine commented Aug 14, 2025

@photocyte - it seems your changes result in Codespaces and devcontainers-on-a-windows-devevelopment-machine working just fine (in my hands at least), so they can definitely be incorporated.

Because those changes you proposed would universally help Mac developers across all projects in the https://github.com/LabAutomationAndScreening ecosystem, I updated the template repositories that this repository uses, and then used copier to pull in the changes.

Let me know if you see anything missing in this PR that was in yours. If not, then I'll merge this one in, and then any future repositories created with those templates will automatically be more Mac-developer friendly thanks to your suggestions

@photocyte
Copy link

Thanks @ejfine ! Looks good to me, LGTM! Closes #30

@ejfine ejfine merged commit e3ca8b0 into main Aug 14, 2025
9 checks passed
@ejfine ejfine deleted the copier-mac branch August 14, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants