Github required-check CI job misses some possibilities

[ejfine]

Is there an existing issue for this?

• I have searched the existing issues

What you expected to see, versus what you actually saw

Right now the gate only treats failure|cancelled as failures. GitHub job results can also be timed_out and action_required, which would incorrectly pass Line 179-182 and allow the workflow to succeed. Consider expanding the pattern.

Or, consider explicitly checking for the "good" statuses

[ejfine]

@zendern - do you see any downside of switching this to just explicitly check for the "allowed" conditions? which appear to only be "completed" or "skipped" ?

https://docs.github.com/en/graphql/reference/enums#checkrunstate

[zendern]

@zendern - do you see any downside of switching this to just explicitly check for the "allowed" conditions? which appear to only be "completed" or "skipped" ?

https://docs.github.com/en/graphql/reference/enums#checkrunstate

Yah no issues there. I think we would want skipped, completed and success based on those docs.

[ejfine]

#129