Skip to content

Update pre-commit excludes#108

Merged
ejfine merged 4 commits intomainfrom
excludes
Nov 9, 2025
Merged

Update pre-commit excludes#108
ejfine merged 4 commits intomainfrom
excludes

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Nov 9, 2025

Why is this change necessary?

Exclude code-gen from docformatter hook

What side effects does this change have?

None

How is this change tested?

Downstream repos

Other

bumps some misc versions

Summary by CodeRabbit

  • Chores
    • Updated development environment configuration and code quality tool settings
    • Updated multiple project dependency versions for improved compatibility and stability

@ejfine ejfine self-assigned this Nov 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

Walkthrough

Devcontainer context hash updated; pre-commit configuration extended with new file exclusions and description-wrapping argument; context variables updated with new dependency versions (httpx, python_kiota_bundle) and Pulumi/Nuxt/Node.js version bumps; template context file updated to expose new versioned dependencies.

Changes

Cohort / File(s) Summary
Devcontainer Configuration
.devcontainer/devcontainer.json
Context hash updated from fbd1043f to 53d51a57; no functional changes
Pre-commit Configuration
.pre-commit-config.yaml
Docformatter exclude patterns converted to multiline verbose format with open-api file exclusions added; new argument --wrap-descriptions=150 added
Context Version Management
extensions/context.py, template/extensions/context.py.jinja-base
Pulumi versions bumped (3.205.0→3.206.0, 7.10.0→7.11.0, 1.37.0→1.38.0); types_node_version updated (^24.9.2→^24.10.0); nuxt_fonts_version bumped (^0.11.4→^0.12.1); new entries added: httpx_version (0.28.1) and python_kiota_bundle_version (1.9.7)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Version bumps and new context entries are repetitive and straightforward to verify
  • Pre-commit pattern changes are clearly scoped to docformatter exclusions
  • Devcontainer hash change is cosmetic and non-functional

Possibly related PRs

  • Bump context #73: Modifies the same context-building logic in extensions/context.py and template files by adding/updating version keys
  • OpenAPI codegen support #102: Updates the same template context updater (extensions/context.py and template/extensions/context.py.jinja-base) to add new version keys to ContextUpdater hook
  • Coderabbit extension #100: Modifies the same files (extensions/context.py, devcontainer.json, and .pre-commit-config.yaml) to bump context version entries and adjust pre-commit settings

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update pre-commit excludes' accurately describes the primary change shown in .pre-commit-config.yaml, where docformatter exclude patterns are extended. However, it omits the significant version updates in extensions/context.py and the template file.
Description check ✅ Passed The description covers key sections (Why, Side effects, How tested, Other) but lacks specific details on which versions were bumped and is missing the 'How does this change address the issue?' section from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25aeca8 and 3d61410.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .pre-commit-config.yaml (1 hunks)
  • extensions/context.py (3 hunks)
  • template/extensions/context.py.jinja-base (1 hunks)
🔇 Additional comments (8)
.devcontainer/devcontainer.json (1)

64-64: LGTM! Automated context hash update.

The devcontainer context hash has been automatically updated by the pre-commit hook, reflecting the configuration changes in this PR.

.pre-commit-config.yaml (2)

143-149: Good practice: Excluding generated code from docformatter.

The extended exclude pattern now properly excludes generated OpenAPI files from docformatter, aligning with the PR objective. The multiline verbose format improves readability and is consistent with other exclusion patterns in this configuration.


153-153: Excellent addition for consistency.

Adding --wrap-descriptions=150 to match the existing --wrap-summaries=150 ensures consistent docstring formatting throughout the codebase.

template/extensions/context.py.jinja-base (1)

44-45: LGTM! New context variables properly exposed.

The new httpx_version and python_kiota_bundle_version context entries are correctly defined and logically placed before the Node.js-related variables. These align with the corresponding concrete values in extensions/context.py.

extensions/context.py (4)

69-69: LGTM! Node.js types updated.

The types_node_version has been updated to ^24.10.0, keeping the TypeScript type definitions current with Node.js 24.x.


77-77: LGTM! Nuxt fonts module updated.

The nuxt_fonts_version has been updated to ^0.12.1, ensuring the latest features and fixes for the Nuxt fonts module.


28-30: Pulumi version updates verified as secure.

All three Pulumi packages are free from known security vulnerabilities: pulumi 3.206.0, pulumi-aws 7.11.0, and pulumi-aws-native 1.38.0 show no security advisories. Ensure compatibility with your infrastructure setup through testing.


49-50: No security concerns identified—versions are current and safe.

Verification confirms httpx 0.28.1 is the latest version and python-kiota-bundle 1.9.7 is the latest version (released Sep 9, 2025). The security advisory check revealed httpx had a CRITICAL vulnerability for versions < 0.23.0; version 0.28.1 is well above this threshold and unaffected. No vulnerabilities were found for kiota-bundle 1.9.7.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ejfine ejfine requested a review from Copilot November 9, 2025 15:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various dependency versions and improves the pre-commit configuration for docformatter exclusions.

  • Updates multiple package versions (Pulumi, Node types, Nuxt fonts)
  • Adds two new Python dependencies: httpx (0.28.1) and python-kiota-bundle (1.9.7)
  • Refactors docformatter exclude pattern to use verbose regex format and adds exclusion for generated OpenAPI files

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
template/extensions/context.py.jinja-base Adds template variables for httpx and python-kiota-bundle versions
extensions/context.py Updates Pulumi packages (3.206.0, 7.11.0, 1.38.0), Node types (24.10.0), Nuxt fonts (0.12.1), and adds httpx and python-kiota-bundle dependencies
.pre-commit-config.yaml Refactors docformatter exclude pattern to verbose regex format and adds exclusion for generated OpenAPI files
.devcontainer/devcontainer.json Updates devcontainer context hash to reflect dependency changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ejfine ejfine merged commit e6d50f9 into main Nov 9, 2025
12 checks passed
@ejfine ejfine deleted the excludes branch November 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants