Skip to content

Whitespace#113

Merged
ejfine merged 8 commits intomainfrom
spaces
Nov 26, 2025
Merged

Whitespace#113
ejfine merged 8 commits intomainfrom
spaces

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Nov 26, 2025

Why is this change necessary?

fix whitespace in YAML comments in CI files

How does this change address the issue?

fixes it

What side effects does this change have?

N/A

How is this change tested?

Downstream repos

Other

switches maintained badge to HTTPS
Bumps some context versions

Summary by CodeRabbit

  • Chores

    • Updated dependencies including Strawberry GraphQL (0.287.0), Nuxt UI (4.2.1), and TypeScript Node types (24.10.1)
    • Added support for Kiota CLI version tracking (1.29.0)
  • Documentation

    • Updated OpenIssues badge to use HTTPS

✏️ Tip: You can customize this high-level summary in your review settings.

@ejfine ejfine self-assigned this Nov 26, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Warning

Rate limit exceeded

@ejfine has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b64524 and 0d97aa5.

📒 Files selected for processing (1)
  • .coveragerc (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The PR updates several dependency versions (strawberry_graphql, nuxt_ui, types_node), introduces kiota_cli_version to context configurations across both production and template extensions, standardizes comment formatting in GitHub workflow YAML files, and updates the README OpenIssues badge URL from HTTP to HTTPS.

Changes

Cohort / File(s) Summary
Version dependencies and context updates
extensions/context.py, template/extensions/context.py.jinja-base
Updated dependency versions: strawberry_graphql_version (0.284.1 → 0.287.0), nuxt_ui_version (^4.1.0 → ^4.2.1), types_node_version (^24.10.0 → ^24.10.1). Added kiota_cli_version context key with value 1.29.0. Reordered Python version keys in template context.
GitHub workflow formatting
template/.github/reusable_workflows/build-docker-image.yaml.jinja-base, template/.github/workflows/ci.yaml.jinja-base, template/.github/workflows/pre-commit.yaml.jinja-base, template/template/.github/workflows/{%\ if\ template_uses_pulumi\ %}pulumi-aws.yml{%\ endif\ %}.jinja-base
Standardized comment alignment in timeout-minutes configuration lines across workflow files (two spaces before inline comments).
Documentation
template/README.md.jinja-base
Updated OpenIssues badge URL from HTTP to HTTPS.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify compatibility of updated dependency versions (strawberry_graphql 0.287.0, nuxt_ui 4.2.1, types_node 24.10.1)
  • Confirm kiota_cli_version 1.29.0 is the intended version and that the context key placement is correct in both context files
  • Verify that workflow comment formatting changes don't affect YAML parsing

Possibly related PRs

Pre-merge checks

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title 'Whitespace' is vague and generic, using a non-descriptive term that does not convey meaningful information about the changeset. Use a more descriptive title that captures the main changes, such as 'Fix YAML comment formatting in CI workflows and bump versions' or 'Normalize whitespace in CI files and update badge URLs'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the template structure and covers key sections, though some entries are minimal or vague ('fixes it', 'N/A').

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses whitespace formatting inconsistencies in YAML workflow files, improves security by switching a badge URL to HTTPS, and updates several dependency versions.

  • Standardizes YAML inline comment spacing to use double spaces before comments
  • Updates badge URL from HTTP to HTTPS for the isitmaintained.com service
  • Bumps dependency versions (strawberry-graphql, nuxt-ui, types-node) and adds kiota_cli_version

Reviewed changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
template/extensions/context.py.jinja-base Adds kiota_cli_version to context variables for template generation
template/README.md.jinja-base Updates isitmaintained.com badge URL from HTTP to HTTPS for improved security
template/.github/workflows/pre-commit.yaml.jinja-base Fixes whitespace formatting - adds second space before inline comment on timeout-minutes
template/.github/workflows/ci.yaml.jinja-base Fixes whitespace formatting - adds second space before inline comment on timeout-minutes
template/.github/reusable_workflows/build-docker-image.yaml.jinja-base Fixes whitespace formatting - adds second space before inline comment on timeout-minutes
extensions/context.py Updates strawberry_graphql_version (0.284.1→0.287.0), nuxt_ui_version (^4.1.0→^4.2.1), types_node_version (^24.10.0→^24.10.1), and adds kiota_cli_version (1.29.0)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 107 to 111
context["kiota_cli_version"] = "{{ kiota_cli_version }}"

context["debian_release_name"] = "{{ debian_release_name }}"
context["alpine_image_version"] = "{{ alpine_image_version }}"
context["nginx_image_version"] = "{{ nginx_image_version }}"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of kiota_cli_version is inconsistent between this file and extensions/context.py. In extensions/context.py, it's placed after nginx_image_version (line 114), but in this template file, it's placed after the Python versions (line 107) and before debian_release_name. These files should maintain the same ordering of context variables for consistency and maintainability.

Suggested change
context["kiota_cli_version"] = "{{ kiota_cli_version }}"
context["debian_release_name"] = "{{ debian_release_name }}"
context["alpine_image_version"] = "{{ alpine_image_version }}"
context["nginx_image_version"] = "{{ nginx_image_version }}"
context["debian_release_name"] = "{{ debian_release_name }}"
context["alpine_image_version"] = "{{ alpine_image_version }}"
context["nginx_image_version"] = "{{ nginx_image_version }}"
context["kiota_cli_version"] = "{{ kiota_cli_version }}"

Copilot uses AI. Check for mistakes.
@ejfine ejfine merged commit ea647a0 into main Nov 26, 2025
6 checks passed
@ejfine ejfine deleted the spaces branch November 26, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants