Skip to content

Fix for git-lfs failures#128

Merged
zendern merged 1 commit intomainfrom
devcontainer-fixes
Feb 3, 2026
Merged

Fix for git-lfs failures#128
zendern merged 1 commit intomainfrom
devcontainer-fixes

Conversation

@zendern
Copy link
Contributor

@zendern zendern commented Feb 3, 2026

Link to Issue or Message thread

See LabAutomationAndScreening/copier-nuxt-python-intranet-app#117

Why is this change necessary?

Propogating the devcontainers fix for failures to init git-lfs hook when we already have pre-commit in place. This impacts both devcontainers and codespaces.

How does this change address the issue?

Explicitly adds the git-lfs feature (which is a transitive already) and sets the "autoPull" property to false. This makes it so the hook wont be installed. If we ever end up needing git-lfs we can figure out how to make this and pre-commit play nicely together.

Note

As stated in the other PR i did try to fiddle the pre-commit install order and it did not help it kept failing out.

What side effects does this change have?

Not git hook attempted to be setup for git-lfs so the container then fully initializes since there are no failures.

How is this change tested?

Locally spinning up devcontainer as well as using using it previously with the fix in the python/nuxt template.

Summary by CodeRabbit

  • Chores
    • Updated development container configuration to include Git LFS with auto-pull disabled to prevent pre-commit hook interference during development.

@zendern zendern requested a review from ejfine February 3, 2026 16:00
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The changes add git-lfs feature configuration to two devcontainer files, explicitly disabling auto-pull to prevent pre-commit hook issues. Both updates include explanatory comments describing the rationale.

Changes

Cohort / File(s) Summary
Git-LFS Feature Configuration
.devcontainer/devcontainer.json, template/.devcontainer/devcontainer.json.jinja-base
Adds git-lfs feature (v1.2.5) with autoPull set to false to prevent pre-commit hooks from triggering during container setup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: fixing git-lfs failures in devcontainer configuration.
Description check ✅ Passed The description includes all required template sections with substantial detail: issue link, rationale, solution approach, side effects, and testing methodology.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zendern zendern merged commit 8545986 into main Feb 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants