-
Notifications
You must be signed in to change notification settings - Fork 1
Deal with more Yarn GPG problems #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4cefaf2
10f2d0c
164fa85
fe511c3
bd1bea4
8312b1a
e68b9cc
338b75a
29243bb
8d4006a
9f4c84e
15cfaa6
fd37404
bf31768
ee048b9
7031d07
a5f91a4
22b3cfe
3b91bcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| ## Link to Issue or Message thread | ||
| ## Link to Issue or Message thread | ||
|
|
||
|
|
||
|
|
||
| ## Why is this change necessary? | ||
| ## Why is this change necessary? | ||
|
|
||
|
|
||
|
|
||
| ## How does this change address the issue? | ||
| ## How does this change address the issue? | ||
|
|
||
|
|
||
|
|
||
| ## What side effects does this change have? | ||
| ## What side effects does this change have? | ||
|
|
||
|
|
||
|
|
||
| ## How is this change tested? | ||
| ## How is this change tested? | ||
|
|
||
|
|
||
|
|
||
| ## Other | ||
| ## Other |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,17 +14,18 @@ | |
| // view latest version https://raw.githubusercontent.com/aws/aws-cli/v2/CHANGELOG.rst | ||
| "version": "2.32.6", | ||
| },{% endraw %}{% endif %}{% raw %} | ||
| "ghcr.io/devcontainers/features/python:1.7.1": { | ||
| "ghcr.io/devcontainers/features/python:1.8.0": { | ||
| // https://github.com/devcontainers/features/blob/main/src/python/devcontainer-feature.json | ||
| "version": "{% endraw %}{{ python_version }}{% raw %}", | ||
| "installTools": false, | ||
| "optimize": true | ||
| }{% endraw %}{% if is_child_of_copier_base_template is not defined and template_uses_javascript is defined and template_uses_javascript is sameas(true) %}{% raw %}, | ||
| "ghcr.io/devcontainers/features/node:1.6.3": { | ||
| // https://github.com/devcontainers/features/tree/main/src/node | ||
| "ghcr.io/devcontainers/features/node:1.7.1": { | ||
| // https://github.com/devcontainers/features/blob/main/src/node/devcontainer-feature.json | ||
| "version": "{% endraw %}{{ node_version }}{% raw %}", | ||
| "pnpmVersion": "{% endraw %}{{ pnpm_version }}{% raw %}" | ||
| }{% endraw %}{% endif %}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %}, | ||
| // https://github.com/anthropics/devcontainer-features/blob/main/src/claude-code/devcontainer-feature.json | ||
| "ghcr.io/anthropics/devcontainer-features/claude-code:1.0.5": {}{% endraw %}{% endif %}{% raw %} | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "customizations": { | ||
|
|
@@ -34,18 +35,18 @@ | |
| "-AmazonWebServices.aws-toolkit-vscode", // the AWS CLI feature installs this automatically, but it's causing problems in VS Code{% endraw %}{% endif %}{% raw %} | ||
| // basic tooling | ||
| // "eamodio.gitlens@15.5.1", | ||
| "coderabbit.coderabbit-vscode@0.16.6", | ||
| "coderabbit.coderabbit-vscode@0.17.0", | ||
| "ms-vscode.live-server@0.5.2025051301", | ||
| "MS-vsliveshare.vsliveshare@1.0.5905", | ||
| "github.copilot@1.388.0", | ||
| "github.copilot-chat@0.36.2026010502",{% endraw %}{% if install_claude_cli %}{% raw %} | ||
| "anthropic.claude-code@2.0.75",{% endraw %}{% endif %}{% raw %} | ||
| "github.copilot-chat@0.38.2026022001",{% endraw %}{% if install_claude_cli %}{% raw %} | ||
| "anthropic.claude-code@2.1.49",{% endraw %}{% endif %}{% raw %} | ||
|
|
||
| // Python | ||
| "ms-python.python@2025.21.2026010501", | ||
| "ms-python.vscode-pylance@2025.10.100", | ||
| "ms-python.python@2026.2.2026021801", | ||
| "ms-python.vscode-pylance@2026.1.1", | ||
| "ms-vscode-remote.remote-containers@0.414.0", | ||
| "charliermarsh.ruff@2025.32.0", | ||
| "charliermarsh.ruff@2026.36.0", | ||
| {% endraw %}{% if is_child_of_copier_base_template is not defined and template_uses_vuejs is defined and template_uses_vuejs is sameas(true) %}{% raw %} | ||
| // VueJS | ||
| "vue.volar@3.2.1", | ||
|
|
@@ -59,7 +60,7 @@ | |
| "samuelcolvin.jinjahtml@0.20.0", | ||
| "tamasfe.even-better-toml@0.19.2", | ||
| "emilast.LogFileHighlighter@3.3.3", | ||
| "esbenp.prettier-vscode@11.0.2" | ||
| "esbenp.prettier-vscode@12.3.0" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result:
[1] Release notes for prettier/prettier-vscode v12.3.0 mention fixes including Windows config change detection and watching Version 12.3.0 was published around Jan 21–22, 2026 (mirrors/package trackers show those dates). [3] Sources: [1] (qiita.com) [2] (newreleases.io) [3] (sourceforge.net) Citations:
🌐 Web query:
💡 Result: Version 12+ of the Prettier VS Code extension is being migrated from What to change for the v12 migration
If you share your current Sources: [1] 🌐 Web query:
💡 Result:
Sources: [1] [2] [3] Use The prettier VS Code extension is migrating from Update to: diff- "esbenp.prettier-vscode@12.3.0"
+ "prettier.prettier-vscode@12.3.0"Or stay on the latest stable 🤖 Prompt for AI Agents
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check your sources. I see the extension page saying the opposite There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query: 💡 Result:
For offline/enterprise install, a commonly used Marketplace package URL for that exact version is: [3] Sources: [1] (github.com) [2] (sourceforge.net) [3] (qiita.com) Citations:
🌐 Web query: 💡 Result: The official VS Code Prettier - Code formatter extension is published on the Visual Studio Marketplace under:
Sources: [1], [2]
Thank you for pushing back on this! |
||
| ], | ||
| "settings": { | ||
| "editor.accessibilitySupport": "off", // turn off sounds | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
The GPG keyring file is written but never referenced by any apt source.
Line 9 removes
yarn.list, so apt will no longer contact the Yarn repository. Line 10 downloads and stores the Yarn GPG key to/etc/apt/keyrings/yarn-archive-keyring.gpg, but with no corresponding entry in/etc/apt/sources.list.d/referencing that keyring, the downloaded key serves no purpose. If the only goal is to preventapt-get updatefailures from the expired Yarn GPG key, removingyarn.listalone is sufficient.♻️ Simplified fix (remove yarn source only)
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was 100% my first question. It should not contact it if its not defined in sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zendern, exactly—sinceyarn.listis removed, apt won't attempt to fetch from the Yarn repository, making the keyring download on line 10 unnecessary. If the goal is simply to avoid GPG failures duringapt-get update, removingyarn.listalone should suffice.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all I can tell you is that the codespace build failed in that link I sent you Zender, and new I can get things to pass :elmo-shrug: