Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .claude/helpers/merge-claude-settings.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ merged_json=$(echo "$parsed_json" | jq -s '
# Collect allow patterns from all files, flatten, and deduplicate
allow: ([.[].permissions.allow // [] | .[] ] | unique),

# Collect ask patterns from all files, flatten, and deduplicate
ask: ([.[].permissions.ask // [] | .[] ] | unique),

# Collect deny patterns from all files, flatten, and deduplicate
deny: ([.[].permissions.deny // [] | .[] ] | unique)
}
Expand Down
2 changes: 1 addition & 1 deletion .coderabbit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ reviews:
- path: "**/vendor_files/**"
instructions: "These files came from a vendor and we're not allowed to change them. Refer to it if you need to understand how the main code interacts with it, but do not make comments about it."
- path: "**/*.py"
instructions: "Do not express concerns about assert statements being removed by using the -O python flag; we never use that flag. Do not express concerns about ruff rules; a pre-commit hook already runs a ruff check. Do not warn about unnecessary super().init() calls; pyright prefers those to be present."
instructions: "Check the `ruff.toml` and `ruff-test.toml` for linting rules we've explicitly disabled and don't suggest changes to please conventions we've disabled. Do not express concerns about ruff rules; a pre-commit hook already runs a ruff check. Do not warn about unnecessary super().__init__() calls; pyright prefers those to be present. Do not warn about missing type hints; a pre-commit hook already checks for that."
tools:
eslint: # when the code contains typescript, eslint will be run by pre-commit, and coderabbit often generates false positives
enabled: false
Expand Down
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"-AmazonWebServices.aws-toolkit-vscode", // the AWS CLI feature installs this automatically, but it's causing problems in VS Code
// basic tooling
// "eamodio.gitlens@15.5.1",
"coderabbit.coderabbit-vscode@0.18.1",
"coderabbit.coderabbit-vscode@0.18.3",
"ms-vscode.live-server@0.5.2025051301",
"MS-vsliveshare.vsliveshare@1.0.5905",
"github.copilot@1.388.0",
Expand Down Expand Up @@ -71,5 +71,5 @@
"initializeCommand": "sh .devcontainer/initialize-command.sh",
"onCreateCommand": "sh .devcontainer/on-create-command.sh",
"postStartCommand": "sh .devcontainer/post-start-command.sh"
// Devcontainer context hash (do not manually edit this, it's managed by a pre-commit hook): a6bb81da # spellchecker:disable-line
// Devcontainer context hash (do not manually edit this, it's managed by a pre-commit hook): 2fb97fb0 # spellchecker:disable-line
}
2 changes: 1 addition & 1 deletion .devcontainer/install-ci-tooling.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import subprocess
import sys

UV_VERSION = "0.10.7"
UV_VERSION = "0.10.8"
COPIER_VERSION = "9.12.0"
COPIER_TEMPLATE_EXTENSIONS_VERSION = "0.3.3"
PRE_COMMIT_VERSION = "4.5.1"
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/on-create-command.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repo_root="$(CDPATH= cd -- "$script_dir/.." && pwd)"
mkdir -p "$repo_root/.claude"
chmod -R ug+rwX "$repo_root/.claude"
chgrp -R 0 "$repo_root/.claude" || true
npm --prefix "$repo_root/.claude" install
npm --prefix "$repo_root/.claude" ci

# Install beads for use in Claude planning
npm install -g @beads/bd@0.57.0 # no specific reason for this version, just pinning for best practice
Expand Down
8 changes: 7 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,23 @@
- Don't sort or remove imports manually — pre-commit handles it.
- Always include type hints for pyright in Python
- Respect the pyright rule reportUnusedCallResult; assign unneeded return values to `_`
- Prefer keyword-only parameters: use `*` in Python signatures and destructured options objects in TypeScript.
- Prefer keyword-only parameters (unless a very clear single-argument function): use `*` in Python signatures and destructured options objects in TypeScript.

## Testing
- Always run tests with an explicit path (e.g. uv run pytest tests/unit) — test runners discover all types by default.
- Test coverage requirements are usually at 100%, so when running a subset of tests, always disable test coverage to avoid the test run failing for insufficient coverage.
- Avoid magic values in comparisons in tests in all languages (like ruff rule PLR2004 specifies)
- Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible.

### Python Testing
- When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)`
- Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py`


Comment on lines +15 to +19
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

New Python Testing subsection is helpful; minor formatting nit.

The mocker.spy guidance about ANY for the self argument is a valuable gotcha to document. The advice to check existing helpers prevents duplication.

There's an extra blank line at line 19, and per MD022, the heading at line 15 should have a blank line above it (line 14 is blank but line 13 ends content).

,

📝 Optional formatting fix
 - Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible.

 ### Python Testing
+
 - When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self:  `spy.assert_called_once_with(ANY, expected_arg)`
 - Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py`
-
-
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### Python Testing
- When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)`
- Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py`
- Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible.
### Python Testing
- When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)`
- Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py`
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)

[warning] 15-15: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below

(MD022, blanks-around-headings)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@AGENTS.md` around lines 15 - 19, Edit the "### Python Testing" section in
AGENTS.md: ensure there is exactly one blank line immediately before the "###
Python Testing" heading (add a blank line above the heading if missing) and
remove the extra blank line after the paragraph (the stray blank line at the end
of the subsection). Keep the content unchanged, only adjust surrounding blank
lines around the "### Python Testing" heading and its paragraph.

## Tooling
- Always use `uv run python` instead of `python3` or `python` when running Python commands.
- Check .devcontainer/devcontainer.json for tooling versions (Python, Node, etc.) when reasoning about version-specific stdlib or tooling behavior.
- For frontend work, run commands via `pnpm` scripts from `frontend/package.json`
<!-- Allows better automated utilization of command allow/deny list -->
- When running terminal commands, execute exactly one command per tool call. Do not chain commands with &&, ||, ;, or & unless the user explicitly asks for it. Pipes (|) are allowed for output transformation (e.g., head, tail, grep). If two sequential commands are needed, run them in separate tool calls.

Expand Down
14 changes: 7 additions & 7 deletions extensions/context.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ContextUpdater(ContextHook):
@override
def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
# These are duplicated in the install-ci-tooling.py script in this repository
context["uv_version"] = "0.10.7"
context["uv_version"] = "0.10.8"
context["pre_commit_version"] = "4.5.1"
# These also in pyproject.toml
context["copier_version"] = "==9.12.0"
Expand All @@ -38,7 +38,7 @@ def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
context["pyinstaller_version"] = ">=6.19.0"
context["setuptools_version"] = "80.7.1"
context["strawberry_graphql_version"] = ">=0.298.0"
context["fastapi_version"] = ">=0.129.0"
context["fastapi_version"] = ">=0.135.1"
context["fastapi_offline_version"] = ">=1.7.4"
context["uvicorn_version"] = ">=0.41.0"
context["lab_auto_pulumi_version"] = ">=0.1.18"
Expand All @@ -56,7 +56,7 @@ def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
context["python_faker_version"] = ">=40.4.0"
#######
context["default_node_version"] = "24.11.1"
context["nuxt_ui_version"] = "^4.4.0"
context["nuxt_ui_version"] = "^4.5.1"
context["nuxt_version"] = "^4.3.1"
context["nuxt_icon_version"] = "^2.2.1"
context["typescript_version"] = "^5.9.3"
Expand Down Expand Up @@ -84,17 +84,17 @@ def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
context["vue_test_utils_version"] = "^2.4.6"
context["nuxt_test_utils_version"] = "3.19.1"
context["vue_eslint_parser_version"] = "^10.4.0"
context["happy_dom_version"] = "^20.6.3"
context["happy_dom_version"] = "^20.8.3"
context["node_kiota_bundle_version"] = "1.0.0-preview.99"
#######
# These are duplicated in the CI files for this repository
context["gha_checkout"] = "v6.0.2"
context["gha_setup_python"] = "v6.2.0"
context["gha_cache"] = "v5.0.2"
context["gha_cache"] = "v5.0.3"
context["gha_linux_runner"] = "ubuntu-24.04"
#######
context["gha_upload_artifact"] = "v6.0.0"
context["gha_download_artifact"] = "v7.0.0"
context["gha_upload_artifact"] = "v7.0.0"
context["gha_download_artifact"] = "v8.0.0"
context["gha_github_script"] = "v7.0.1"
context["gha_setup_buildx"] = "v3.11.1"
context["buildx_version"] = "v0.27.0"
Expand Down
2 changes: 1 addition & 1 deletion template/.devcontainer/devcontainer.json.jinja-base
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"-AmazonWebServices.aws-toolkit-vscode", // the AWS CLI feature installs this automatically, but it's causing problems in VS Code{% endraw %}{% endif %}{% raw %}
// basic tooling
// "eamodio.gitlens@15.5.1",
"coderabbit.coderabbit-vscode@0.18.1",
"coderabbit.coderabbit-vscode@0.18.3",
"ms-vscode.live-server@0.5.2025051301",
"MS-vsliveshare.vsliveshare@1.0.5905",
"github.copilot@1.388.0",
Expand Down
2 changes: 1 addition & 1 deletion template/.devcontainer/on-create-command.sh.jinja-base
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repo_root="$(CDPATH= cd -- "$script_dir/.." && pwd)"
mkdir -p "$repo_root/.claude"
chmod -R ug+rwX "$repo_root/.claude"
chgrp -R 0 "$repo_root/.claude" || true
npm --prefix "$repo_root/.claude" install
npm --prefix "$repo_root/.claude" ci

# Install beads for use in Claude planning
npm install -g @beads/bd@0.57.0 # no specific reason for this version, just pinning for best practice{% endraw %}{% endif %}{% raw %}
Expand Down