Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBumps multiple tooling/dependency versions, adds guidance for batch collection assertions in AGENTS.md, and refactors GitHub Actions ECR authentication by introducing a reusable composite action and removing the separate ECR login step. (47 words) Changes
Sequence Diagram(s)mermaid Workflow->>EcrAuth: invoke (aws-region, role-arn) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@template/template/.github/actions/ecr-auth/action.yml.jinja`:
- Line 6: Remove the unsupported `type` attribute from the composite action
inputs in the action metadata: locate the `inputs` blocks (the `inputs.*.type`
fields) in the composite action template and delete the `type: string` lines
(also remove the duplicate `type` at the other noted occurrence). Leave only the
supported keys (`description`, `required`, `default`, `deprecationMessage`) for
each input so the generated action.yml is valid for composite actions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9669de0d-e1db-413c-ad15-b05ac2ae68e3
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.devcontainer/devcontainer.jsonAGENTS.mdextensions/context.pypyproject.tomltemplate/.github/reusable_workflows/build-docker-image.yaml.jinja-basetemplate/template/.github/actions/ecr-auth/action.yml.jinja
There was a problem hiding this comment.
Pull request overview
Adds a reusable GitHub composite action to centralize AWS ECR OIDC auth + login, and updates the Docker image build reusable workflow to consume it, alongside routine version bumps in template/tooling dependencies.
Changes:
- Introduce an
ecr-authcomposite action intended to handleconfigure-aws-credentials+amazon-ecr-login. - Refactor the reusable Docker build workflow to use the local
ecr-authaction and remove the standalone ECR login step. - Bump versions for copier/uv and multiple template-pinned GitHub Action versions; update related docs and devcontainer tooling pins.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
template/template/.github/actions/ecr-auth/action.yml.jinja |
Adds new composite action for ECR auth/login (currently has template path/suffix issues). |
template/.github/reusable_workflows/build-docker-image.yaml.jinja-base |
Switches ECR auth/login steps to use the new local composite action. |
extensions/context.py |
Bumps pinned tool and GitHub Action versions used across templates. |
pyproject.toml |
Updates copier dependency pin. |
uv.lock |
Updates locked copier version/artifacts. |
.devcontainer/install-ci-tooling.py |
Updates pinned UV and copier versions for CI/devcontainer setup. |
.devcontainer/devcontainer.json |
Updates generated devcontainer context hash comment. |
AGENTS.md |
Expands testing guidance (minor markdown formatting issue introduced). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {% raw %}name: AWS ECR Auth | ||
| description: 'Use OIDC to Authenticate and login to an AWS ECR.' | ||
|
|
| - name: OIDC Auth for ECR | ||
| if: ${{ inputs.push-role-name != 'no-push' }} | ||
| uses: aws-actions/configure-aws-credentials@{% endraw %}{{ gha_configure_aws_credentials }}{% raw %} | ||
| uses: ./.github/actions/ecr-auth |
| - name: OIDC Auth for ECR | ||
| if: ${{ inputs.push-role-name != 'no-push' }} | ||
| uses: aws-actions/configure-aws-credentials@{% endraw %}{{ gha_configure_aws_credentials }}{% raw %} | ||
| uses: ./.github/actions/ecr-auth | ||
| with: |
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: OIDC Auth for ECR to pull Data Hub images |
AGENTS.md
Outdated
| - Avoid magic values in comparisons in tests in all languages (like ruff rule PLR2004 specifies) | ||
| - Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible. | ||
| - Avoid loops in tests — assert each item explicitly so failures pinpoint the exact element. | ||
| - Avoid loops in tests — assert each item explicitly so failures pinpoint the exact element. When verifying a condition across all items in a collection, collect the violations into a list and assert it's empty (e.g., assert [x for x in items if bad_condition(x)] == []). |
Why is this change necessary?
Needed to DRY up a bunch of code in workflows in this template and other ones created in child templates
How does this change address the issue?
Adds action
What side effects does this change have?
N/A
How is this change tested?
Downstream repo
Other
Bumped some versions of things
Summary by CodeRabbit
Chores
Documentation