Skip to content

Update image build job to output the computed tag#138

Merged
ejfine merged 3 commits intomainfrom
agents4
Mar 20, 2026
Merged

Update image build job to output the computed tag#138
ejfine merged 3 commits intomainfrom
agents4

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Mar 20, 2026

Why is this change necessary?

Needed for LabAutomationAndScreening/copier-nuxt-python-intranet-app#132

How does this change address the issue?

Outputs the tag and DRYs up places where it was computed

What side effects does this change have?

N/A

How is this change tested?

Downstream child and grandchild repos

Other

Made minor adjustments to AGENTS.md

Summary by CodeRabbit

  • Documentation

    • Updated workflow guidelines for linting and type-checking procedures, providing clear specifications for using pre-commit hooks with designated hook identifiers for all code quality checks.
  • Chores

    • Enhanced Docker image build workflow infrastructure with a new unified image tag output mechanism, improving consistency and standardization across Docker image pull and build tagging operations.

@ejfine ejfine self-assigned this Mar 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Warning

Rate limit exceeded

@ejfine has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 4 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c1c56533-caab-4564-8658-c7e5ea08183d

📥 Commits

Reviewing files that changed from the base of the PR and between d96466d and 0f59906.

📒 Files selected for processing (1)
  • template/.github/reusable_workflows/build-docker-image.yaml.jinja-base
📝 Walkthrough

Walkthrough

Updated AGENTS.md documentation with linting workflow guidance, specifying the use of pre-commit run <hook-id> for type-checking and linting tasks. Added a new full-image-tag output to the Docker build workflow that consolidates image tag generation and updates Docker pull and build operations to use this unified output.

Changes

Cohort / File(s) Summary
Documentation
AGENTS.md
Updated linting/type-checking workflow guidance to use pre-commit run with specific hook IDs instead of directly invoking underlying tools.
Docker Build Workflow
template/.github/reusable_workflows/build-docker-image.yaml.jinja-base
Added new workflow output full-image-tag combining repository, image name, and build context hash. Updated Docker pull and Buildx tag operations to use the new unified output instead of directly constructing the tag value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • idonaldson
  • zendern
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding output of the computed tag from the image build job.
Description check ✅ Passed The description covers all required template sections with relevant information about the change's necessity, implementation, testing, and side effects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
template/.github/reusable_workflows/build-docker-image.yaml.jinja-base (1)

155-155: 🧹 Nitpick | 🔵 Trivial

Consider using full_image_tag for consistency.

This line still manually constructs the tag (${{ inputs.repository }}/${{ inputs.image_name }}:${{ steps.calculate-build-context-hash.outputs.build_context_tag }}) instead of using the new unified full_image_tag output. While functionally equivalent, using the consolidated output would maintain consistency and reduce maintenance burden if the tag format changes.

♻️ Proposed refactor
-        run: docker save -o ${{ steps.calculate-build-context-hash.outputs.image_name_no_slashes }}.tar ${{ inputs.repository }}/${{ inputs.image_name }}:${{ steps.calculate-build-context-hash.outputs.build_context_tag }}
+        run: docker save -o ${{ steps.calculate-build-context-hash.outputs.image_name_no_slashes }}.tar ${{ steps.calculate-build-context-hash.outputs.full_image_tag }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@template/.github/reusable_workflows/build-docker-image.yaml.jinja-base` at
line 155, Replace the manually constructed image reference in the docker save
step with the unified output full_image_tag: keep the existing output filename
reference steps.calculate-build-context-hash.outputs.image_name_no_slashes for
the -o argument, but use the consolidated full_image_tag (the new output that
represents the complete repository/image:tag) instead of manually concatenating
inputs.repository, inputs.image_name and
steps.calculate-build-context-hash.outputs.build_context_tag; update the run
line to reference full_image_tag so future tag-format changes are centralized.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@template/.github/reusable_workflows/build-docker-image.yaml.jinja-base`:
- Line 155: Replace the manually constructed image reference in the docker save
step with the unified output full_image_tag: keep the existing output filename
reference steps.calculate-build-context-hash.outputs.image_name_no_slashes for
the -o argument, but use the consolidated full_image_tag (the new output that
represents the complete repository/image:tag) instead of manually concatenating
inputs.repository, inputs.image_name and
steps.calculate-build-context-hash.outputs.build_context_tag; update the run
line to reference full_image_tag so future tag-format changes are centralized.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 136a6b2c-2463-4b9e-b44d-7a2714012429

📥 Commits

Reviewing files that changed from the base of the PR and between 96e65cc and d96466d.

📒 Files selected for processing (2)
  • AGENTS.md
  • template/.github/reusable_workflows/build-docker-image.yaml.jinja-base

@ejfine ejfine marked this pull request as ready for review March 20, 2026 16:04
@ejfine ejfine requested review from idonaldson and zendern March 20, 2026 16:04
@ejfine ejfine merged commit 974bb18 into main Mar 20, 2026
7 checks passed
@ejfine ejfine deleted the agents4 branch March 20, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants