Skip to content

More Agent instructions#139

Merged
ejfine merged 12 commits intomainfrom
so-many-more-agents
Mar 23, 2026
Merged

More Agent instructions#139
ejfine merged 12 commits intomainfrom
so-many-more-agents

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Mar 23, 2026

Why is this change necessary?

Reformat the AGENTS.md into distinct sections and add a few more rules

What side effects does this change have?

N/A

How is this change tested?

Downstream repos

Other

Bumps pytest-cov and uv

Summary by CodeRabbit

  • Chores

    • Updated development tooling and devcontainer metadata; bumped installer and test tooling versions and coverage dependency.
  • Documentation

    • Added project-structure guidance, explicit confirmation rules for saving memory/adding rules, stricter type-safety/style guidance, testing guidance (prefer faker fixture), and tooling/codegen rules for linting and regenerated files.

@coderabbitai
Copy link

coderabbitai bot commented Mar 23, 2026

Warning

Rate limit exceeded

@ejfine has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e455b024-32c7-4f1f-9ec9-e88f55c9812e

📥 Commits

Reviewing files that changed from the base of the PR and between 5bf54f7 and fa56e4d.

📒 Files selected for processing (1)
  • AGENTS.md
📝 Walkthrough

Walkthrough

Updates development tooling versions (uv to 0.10.12, pytest-cov to >=7.1.0), refreshes devcontainer context hash, and adds project-structure and developer rules to AGENTS.md.

Changes

Cohort / File(s) Summary
Devcontainer Configuration
​.devcontainer/devcontainer.json
Updated managed Devcontainer context hash from b93e7b48d5ae7a8e.
Tooling & Context Pins
​.devcontainer/install-ci-tooling.py, extensions/context.py
Bumped uv installer/version from 0.10.100.10.12; updated uv_version in context mapping; bumped pytest_cov_version constraint in context from >=7.0.0>=7.1.0.
Test Dependency
pyproject.toml
Raised pytest-cov constraint from >=7.0.0>=7.1.0.
Documentation
AGENTS.md
Added Project Structure, Agent Implementations & Configurations, Memory and Rules guidance; added code style/testing/tooling directives (faker pytest fixture, ruff via pre-commit, do not edit generated/ files), and rule on explicit confirmation for saving memory/adding rules.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • idonaldson
  • zendern
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic, using a non-descriptive phrase that does not clearly convey the specific changes made to the codebase. Consider a more specific title such as 'Expand AGENTS.md with project structure and tooling guidelines' to better reflect the main changes in the PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description covers most required sections but lacks a clear link to an issue and provides minimal detail on how the changes address the stated need.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@AGENTS.md`:
- Around line 34-37: Add a blank line before the "## Memory and Rules" heading
in AGENTS.md to follow Markdown style conventions; locate the heading text "##
Memory and Rules" and insert a single empty line above it so the heading is
separated from the preceding content.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6e6ed913-fa34-4e69-997b-62f621d8eae4

📥 Commits

Reviewing files that changed from the base of the PR and between 974bb18 and 516145d.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • .devcontainer/devcontainer.json
  • .devcontainer/install-ci-tooling.py
  • AGENTS.md
  • extensions/context.py
  • pyproject.toml

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@AGENTS.md`:
- Line 41: Add a blank line after the "## Tooling" heading in AGENTS.md to
satisfy Markdown style rule MD022; locate the "## Tooling" heading and insert a
single empty line immediately following it so the heading is separated from the
following content.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4e63a7cb-70d5-4b1b-9205-d33bfb9b32cb

📥 Commits

Reviewing files that changed from the base of the PR and between 1584c02 and 5bf54f7.

📒 Files selected for processing (1)
  • AGENTS.md

@ejfine ejfine marked this pull request as ready for review March 23, 2026 14:00
@ejfine ejfine requested a review from zendern March 23, 2026 17:01
@ejfine ejfine merged commit c1f15be into main Mar 23, 2026
7 checks passed
@ejfine ejfine deleted the so-many-more-agents branch March 23, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants