Skip to content

Expose artifact name from build-image job #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejfine merged 4 commits into from
Aug 21, 2025
Merged

Expose artifact name from build-image job #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cdc143
delete
ejfine Aug 21, 2025
e21101a
add output
ejfine Aug 21, 2025
a043819
vitest
ejfine Aug 21, 2025
6252430
pyright
ejfine Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@
"initializeCommand": "sh .devcontainer/initialize-command.sh",
"onCreateCommand": "sh .devcontainer/on-create-command.sh",
"postStartCommand": "sh .devcontainer/post-start-command.sh"
// Devcontainer context hash (do not manually edit this, it's managed by a pre-commit hook): 08c28c62 # spellchecker:disable-line
// Devcontainer context hash (do not manually edit this, it's managed by a pre-commit hook): c75f8c43 # spellchecker:disable-line
}
3 changes: 2 additions & 1 deletion extensions/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
#######
context["pnpm_version"] = "10.14.0"
# These are duplicated in the pyproject.toml of this repository
context["pyright_version"] = "1.1.403"
context["pyright_version"] = "1.1.404"
context["pytest_version"] = "8.4.1"
context["pytest_randomly_version"] = "3.16.0"
context["pytest_cov_version"] = "6.2.1"
Expand Down Expand Up @@ -50,6 +50,7 @@ def hook(self, context: dict[Any, Any]) -> dict[Any, Any]:
context["vue_version"] = "^3.5.18"
context["vue_router_version"] = "^4.5.1"
context["faker_version"] = "^9.9.0"
context["vitest_version"] = "^3.2.4"
context["eslint_version"] = "^9.33.0"
context["zod_version"] = "^4.0.17"
context["nuxt_apollo_version"] = "5.0.0-alpha.15"
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies = [
"pytest>=8.4.0",
"pytest-cov>=6.2.1",
"pytest-randomly>=3.16.0",
"pyright[nodejs]>=1.1.403",
"pyright[nodejs]>=1.1.404",
"copier>=9.8.0",
"copier-template-extensions>=0.3.2"
]
53 changes: 0 additions & 53 deletions template/.devcontainer/manual-setup-deps.sh.jinja-base
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions template/.github/reusable_workflows/build-docker-image.yaml.jinja-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ on:
description: 'Should the image be saved as an artifact?'
required: false
default: false
outputs:
artifact-name:
description: 'The name of the uploaded artifact of the image tarball'
value: ${{ jobs.build-image.outputs.artifact-name }}

permissions:
id-token: write
Expand All @@ -40,6 +44,8 @@ jobs:
build-image:
name: Build Docker Image
runs-on: {% endraw %}{{ gha_linux_runner }}{% raw %}
outputs:
artifact-name: ${{ steps.calculate-build-context-hash.outputs.image_name_no_slashes }}
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output references steps.calculate-build-context-hash.outputs.image_name_no_slashes but there's no visible step with id calculate-build-context-hash in the diff. Verify this step exists and produces the expected output.

Copilot uses AI. Check for mistakes.
steps:
- name: Parse ECR URL
if: ${{ inputs.push-role-name != 'no-push' }}
Expand Down
1 change: 1 addition & 0 deletions template/extensions/context.py.jinja-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ class ContextUpdater(ContextHook):
context["vue_version"] = "{{ vue_version }}"
context["vue_router_version"] = "{{ vue_router_version }}"
context["faker_version"] = "{{ faker_version }}"
context["vitest_version"] = "{{ vitest_version }}"
Copy link

@coderabbitai coderabbitai bot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify vitest_version is defined in copier.yaml and test fixtures

To avoid Jinja UndefinedError during template rendering, ensure vitest_version is present wherever other version vars are defined (e.g., copier.yaml and tests/data*.yml).

Run this to confirm coverage:

If missing, I can add a default in copier.yaml matching extensions/context.py ("^3.2.4").

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Search for vitest_version definitions in config and tests"
# copier config(s)
fd -a -t f 'copier.y*ml' | xargs -r -I{} rg -n --no-heading '^\s*vitest_version\s*:' {} || true
# test fixtures
rg -n --no-heading 'vitest_version' tests || true
# ensure used in templates (expect hits)
rg -n --no-heading 'vitest_version' template || true

Length of output: 443

Define vitest_version in copier.yaml and test fixtures

The template at template/extensions/context.py.jinja-base:48 uses {{ vitest_version }}, but our search shows this variable isn’t defined in any copier configuration or in the test fixtures—this will trigger a Jinja UndefinedError when rendering.

Please add a default vitest_version in your copier config and mirror it in your test data. For example:

• In copier.yaml (or .copier.yaml), under your variables section:

 variables:
   # …existing definitions…
+  vitest_version:
+    type: str
+    default: "^3.2.4"
+    help: "Version of Vitest to install in the generated project"

• In your test fixtures (e.g. tests/data-common.yml or similar):

 # …existing test data…
+vitest_version: "^3.2.4"

These additions will ensure that vitest_version is always defined during both normal usage and in CI/test runs.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
context["vitest_version"] = "{{ vitest_version }}"
# In copier.yaml (or .copier.yaml), under your `variables:` section
variables:
# …existing definitions…
vitest_version:
type: str
default: "^3.2.4"
help: "Version of Vitest to install in the generated project"
Suggested change
context["vitest_version"] = "{{ vitest_version }}"
# In your test fixtures file (e.g. tests/data-common.yml)
# …existing test data…
vitest_version: "^3.2.4"
🤖 Prompt for AI Agents 
In template/extensions/context.py.jinja-base around line 48, the template
references {{ vitest_version }} but that variable is not defined in copier
configuration or test fixtures; add a default vitest_version entry to your
copier config (e.g., in copier.yaml / .copier.yaml under the variables section)
and add the same key/value to your test fixture data file (e.g.,
tests/data-common.yml or the fixtures file your test suite loads) so rendering
never raises a Jinja UndefinedError.

context["eslint_version"] = "{{ eslint_version }}"
context["zod_version"] = "{{ zod_version }}"
context["nuxt_apollo_version"] = "{{ nuxt_apollo_version }}"
Expand Down
10 changes: 5 additions & 5 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.