-
Notifications
You must be signed in to change notification settings - Fork 1
Copier update: misc claude #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,17 +4,23 @@ | |||||||||||||||
| - Don't sort or remove imports manually — pre-commit handles it. | ||||||||||||||||
| - Always include type hints for pyright in Python | ||||||||||||||||
| - Respect the pyright rule reportUnusedCallResult; assign unneeded return values to `_` | ||||||||||||||||
| - Prefer keyword-only parameters: use `*` in Python signatures and destructured options objects in TypeScript. | ||||||||||||||||
| - Prefer keyword-only parameters (unless a very clear single-argument function): use `*` in Python signatures and destructured options objects in TypeScript. | ||||||||||||||||
|
|
||||||||||||||||
| ## Testing | ||||||||||||||||
| - Always run tests with an explicit path (e.g. uv run pytest tests/unit) — test runners discover all types by default. | ||||||||||||||||
| - Test coverage requirements are usually at 100%, so when running a subset of tests, always disable test coverage to avoid the test run failing for insufficient coverage. | ||||||||||||||||
| - Avoid magic values in comparisons in tests in all languages (like ruff rule PLR2004 specifies) | ||||||||||||||||
| - Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible. | ||||||||||||||||
|
|
||||||||||||||||
| ### Python Testing | ||||||||||||||||
| - When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)` | ||||||||||||||||
| - Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py` | ||||||||||||||||
|
Comment on lines
+15
to
+17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a blank line after the Heading spacing is inconsistent with markdownlint expectations. Suggested fix ### Python Testing
+
- When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)`
- Before writing new mock/spy helpers, check the `tests/unit/` folder for pre-built helpers in files like `fixtures.py` or `*mocks.py`📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.21.0)[warning] 15-15: Headings should be surrounded by blank lines (MD022, blanks-around-headings) 🤖 Prompt for AI Agents |
||||||||||||||||
|
|
||||||||||||||||
|
|
||||||||||||||||
| ## Tooling | ||||||||||||||||
| - Always use `uv run python` instead of `python3` or `python` when running Python commands. | ||||||||||||||||
| - Check .devcontainer/devcontainer.json for tooling versions (Python, Node, etc.) when reasoning about version-specific stdlib or tooling behavior. | ||||||||||||||||
| - For frontend work, run commands via `pnpm` scripts from `frontend/package.json` | ||||||||||||||||
| <!-- Allows better automated utilization of command allow/deny list --> | ||||||||||||||||
| - When running terminal commands, execute exactly one command per tool call. Do not chain commands with &&, ||, ;, or & unless the user explicitly asks for it. Pipes (|) are allowed for output transformation (e.g., head, tail, grep). If two sequential commands are needed, run them in separate tool calls. | ||||||||||||||||
|
|
||||||||||||||||
|
|
@@ -104,3 +110,8 @@ bd export -o .claude/.beads/issues-dump.jsonl | |||||||||||||||
| For more details, see README.md and docs/QUICKSTART.md. | ||||||||||||||||
|
|
||||||||||||||||
| <!-- END BEADS INTEGRATION --> | ||||||||||||||||
|
|
||||||||||||||||
| ## Project Structure | ||||||||||||||||
| - This is a statically generated frontend---using the Nuxt and @nuxt/ui frameworks---meant to operate in an air-gapped environment. That code is in the `frontend/` directory. | ||||||||||||||||
| - There may also be a backend that the frontend interacts with, in `backend/`. If present, it will be a Python FastAPI uvicorn server. | ||||||||||||||||
| - Kiota is used for codegen from the OpenAPI schema | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Add blank line before heading per markdownlint.
The
### Python Testingheading should have a blank line above it for proper markdown formatting.📝 Proposed fix
- Prefer using random values in tests rather than arbitrary ones (e.g. the faker library, uuids, random.randint) when possible. + ### Python Testing - When using `mocker.spy` on a class-level method (including inherited ones), the spy records the unbound call, so assertions need `ANY` as the first argument to match self: `spy.assert_called_once_with(ANY, expected_arg)`📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 15-15: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
🤖 Prompt for AI Agents