Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR pulls in upstream changes and updates various dependency versions and configuration values across multiple files.
- Updates versions for Python setup and testing dependencies in action workflows and pyproject configurations
- Revises dependency versions and configuration settings in the context updater, pre-commit setup, and CI workflows
- Introduces new parameters and conditional logic in the reusable Docker build workflow
Reviewed Changes
Copilot reviewed 15 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| template/.github/actions/install_deps_uv/action.yml | Upgrades setup-python action version from v5.4.0 to v5.5.0 |
| pyproject.toml | Bumps versions for pytest, pyright, and copier dependencies |
| extensions/context.py | Updates several dependency versions including switching Windows runner to a newer version |
| copier.yml | Adds a refined default for ssh_port_number and a default for AWS central infrastructure account ID |
| .pre-commit-config.yaml | Upgrades pre-commit hooks (typos, ruff, and adds biome-check) and adjusts file matching patterns |
| .github/workflows/hash_git_files.py | Introduces a new script for computing devcontainer context hash |
| .github/workflows/ci.yaml | Modifies skipping logic in pre-commit runs to ignore devcontainer context hash |
| .github/reusable_workflows/build-docker-image.yaml | Adds new inputs for tag-for-production, push-role-name, and save-as-artifact while refining ECR URL parsing and tagging logic |
| .github/pull_request_template.md | Minor adjustment to thread naming |
| .copier-answers.yml | Updates the copier template commit version |
Files not reviewed (10)
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/install-ci-tooling.sh: Language not supported
- .devcontainer/windows-host-helper.sh: Language not supported
- .github/actions/install_deps_uv/action.yml: Language not supported
- .github/actions/install_deps_uv/install-ci-tooling.ps1: Language not supported
- biome.json: Language not supported
- template/.devcontainer/create-aws-profile.sh.jinja: Language not supported
- template/.devcontainer/devcontainer.json.jinja: Language not supported
- template/.devcontainer/windows-host-helper.sh: Language not supported
- template/.github/actions/install_deps_uv/install-ci-tooling.ps1: Language not supported
Comments suppressed due to low confidence (1)
extensions/context.py:56
- Ensure that the new Windows runner version ('windows-2025') is available and supported by GitHub CI, as this appears to be a future release version.
context["gha_windows_runner"] = "windows-2025"
| args: [--autofix, --no-sort-keys] | ||
|
|
||
| - repo: https://github.com/biomejs/pre-commit | ||
| rev: 748e40d32e076a6aaaf3353a2564c8fe43764f79 # frozen: v2.0.0-beta.1 |
There was a problem hiding this comment.
[nitpick] Consider using a stable release for the biome-check hook rather than a beta version once one becomes available to ensure consistent behavior in production.
Suggested change
| rev: 748e40d32e076a6aaaf3353a2564c8fe43764f79 # frozen: v2.0.0-beta.1 | |
| rev: <latest-stable-version-hash> # frozen: <latest-stable-version> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in upstream changes