Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR pulls upstream changes to update workflow configurations and related scripts, including a new "--exit-zero" flag in the hash update script, an updated Ubuntu version in the Dependabot workflow, and an updated devcontainer context hash alongside a Copier template version bump.
- Added a "--exit-zero" flag to allow process exit with code 0 when the devcontainer hash changes.
- Updated workflow configurations to use Ubuntu 24.04.
- Updated the devcontainer hash and Copier commit version.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| template/.github/workflows/hash_git_files.py | Added "--exit-zero" argument and updated exit code logic for devcontainer updates. |
| template/.github/workflows/dependabot-post-update.yaml | Updated runner version and added the "--exit-zero" flag to the script command. |
| .github/workflows/hash_git_files.py | Added "--exit-zero" argument and updated exit code logic for devcontainer updates. |
| .github/workflows/dependabot-post-update.yaml | Updated runner version and modified the script command with "--exit-zero". |
| .devcontainer/devcontainer.json | Updated the devcontainer context hash comment. |
| .copier-answers.yml | Bumped the Copier commit version. |
| action="store_true", | ||
| help="Update the hash in the devcontainer.json file based on all files relevant to devcontainer context", | ||
| ) | ||
| _ = parser.add_argument("--exit-zero", action="store_true", help="Exit with code 0 even if the hash changes") |
There was a problem hiding this comment.
[nitpick] This same addition appears in multiple locations. Consider consolidating the hash update logic into a shared module to ease future maintenance, provided that the workflows can share common code.
| action="store_true", | ||
| help="Update the hash in the devcontainer.json file based on all files relevant to devcontainer context", | ||
| ) | ||
| _ = parser.add_argument("--exit-zero", action="store_true", help="Exit with code 0 even if the hash changes") |
There was a problem hiding this comment.
[nitpick] This addition duplicates functionality present in the template version of the script. If both copies are intended to remain synchronized, consider refactoring to reduce code duplication.
Pull in upstream changes