Conversation
| - "version-update:semver-patch" | ||
| - dependency-name: "sphinx*" # read-the-docs uses specific versions of sphinx, so we generally want to stay tightly pinned unless there's a major version change | ||
| update-types: | ||
| - "version-update:semver-minor" |
There was a problem hiding this comment.
The update type 'version-update:semver-minor' contradicts the intended behavior described in the PR title and comment. Consider using a setting that prevents minor updates to ensure sphinx remains tightly pinned.
Suggested change
| - "version-update:semver-minor" | |
| - "version-update:semver-patch" |
| - "version-update:semver-patch" | ||
| - dependency-name: "sphinx*" # read-the-docs uses specific versions of sphinx, so we generally want to stay tightly pinned unless there's a major version change | ||
| update-types: | ||
| - "version-update:semver-minor" |
There was a problem hiding this comment.
The PR title indicates that sphinx minor versions should be ignored, but the configuration currently allows semver minor updates. Consider removing or revising the 'version-update:semver-minor' entry to ensure the behavior matches the intended limitation.
Suggested change
| - "version-update:semver-minor" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
dependabot was updating sphinx
How does this change address the issue?
stops it
What side effects does this change have?
N/A
How is this change tested?
isn't