Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR pulls in upstream dependency and tooling updates, migrates installation scripts from shell/PowerShell to Python, and bumps various CI and devcontainer configurations.
- Bump numerous package and action versions in
extensions/context.py, workflows, and configs - Replace shell/PowerShell install scripts with unified Python scripts (
.devcontainer/manual-setup-deps.py,.devcontainer/install-ci-tooling.py) - Update GitHub workflows and devcontainer settings to match new tool versions and improve step logic
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/context.py | Updated many dependency version pins |
| _typos.toml | Added exclude for VCR.py cassette YAML files |
| README.md | Changed install command to use Python installer |
| .pre-commit-config.yaml | Bumped hook revisions and added vendor_files excludes |
| .github/workflows/pre-commit.yaml | Refined checkout steps and bumped cache action |
| .github/workflows/get-values.yaml | Added PR number extraction steps |
| .github/workflows/ci.yaml | Switched to install_deps action and updated cache |
| .github/reusable_workflows/build-docker-image.yaml | Bumped AWS and docker actions versions |
| .github/actions/install_deps/action.yml | Updated inputs schema and installation logic |
| .devcontainer/manual-setup-deps.py | New Python-based dependency setup script |
| .devcontainer/install-ci-tooling.py | New Python-based CI tooling installer |
| .devcontainer/devcontainer.json | Bumped devcontainer feature versions and extensions |
| .devcontainer/Dockerfile | Upgraded base image tag with platform flag |
| .copier-answers.yml | Updated _commit to match new template version |
Comments suppressed due to low confidence (2)
extensions/context.py:27
- Renaming the key from
pulumi_githubtopulumi_github_versionchanges the template API; ensure downstream code is updated to read the new key or consider deprecating the old key for backward compatibility.
context["pulumi_github_version"] = "6.7.2"
.github/workflows/get-values.yaml:47
- This parameter expansion syntax (
${VAR:COND?A:B}) is not valid in POSIX/Bash. Bash does not support inline ternary operators in slice offsets. Consider using an explicit conditional (e.g. anifstatement) to compute the slice index.
short_number=${full_number:${#full_number}<2?0:-2} # only use the last two digits so that the stack name is no more than 7 characters and doesn't get too long. Based on https://stackoverflow.com/questions/19858600/accessing-last-x-characters-of-a-string-in-bash
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| uv-sync: false | ||
| install-deps: false |
There was a problem hiding this comment.
The new install_deps action requires a python-version input to install the correct Python version; the pipeline no longer passes python-version, which may lead to unexpected defaults. Add python-version: ${{ matrix.python-version }} under with:.
| node-version: ${{ inputs.node-version }} | ||
| - name: Checkout code not during push | ||
| if: ${{ github.event_name != 'push' }} | ||
| uses: actions/checkout@v4.2.2 |
There was a problem hiding this comment.
The 'Checkout code not during push' step is missing a with: ref: ${{ github.ref_name }} block, so it may default to the wrong ref. Add the same with stanza as the push checkout step.
| uses: actions/checkout@v4.2.2 | |
| uses: actions/checkout@v4.2.2 | |
| with: | |
| ref: ${{ github.ref_name }} |
Pull in upstream changes