Skip to content

Publish patch#49

Merged
ejfine merged 3 commits intomainfrom
publish-patch
Jun 18, 2025
Merged

Publish patch#49
ejfine merged 3 commits intomainfrom
publish-patch

Conversation

@ejfine
Copy link
Contributor

@ejfine ejfine commented Jun 18, 2025

Why is this change necessary?

In CI, when installing from the pypi testing registry, project sub-dependencies weren't always there

How does this change address the issue?

Added the main PyPI registry as backup

What side effects does this change have?

None

How is this change tested?

Isn't

Other

Pulled in some upstream template updates

@ejfine ejfine requested a review from Copilot June 18, 2025 14:30
@ejfine ejfine self-assigned this Jun 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances CI publishing by adding a fallback main PyPI registry and incorporates various upstream template updates, including version bumps and optional tooling installation.

  • Add --extra-index-url for main PyPI in the CI publish workflow
  • Bump dependency versions in templates and context files
  • Introduce optional AWS SSM plugin installation in devcontainer tooling

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
template/pyproject.toml.jinja Loosened pyright pin to >= and updated test tooling versions
template/.github/workflows/publish.yaml.jinja Added --extra-index-url pointing to main PyPI
template/.github/dependabot.yml.jinja Restricted Dependabot to minor updates only
template/.devcontainer/install-ci-tooling.py.jinja Added Jinja logic and code for optional AWS SSM plugin installation
pyproject.toml Bumped pytest, pytest-cov, and pyright versions
extensions/context.py Updated context version values and added nginx_image_version
.github/dependabot.yml Restricted Dependabot to minor updates only
.devcontainer/install-ci-tooling.py Added optional AWS SSM plugin install logic and version bumps
.devcontainer/devcontainer.json Updated devcontainer context hash
.copier-answers.yml Updated copier-answers commit reference
Comments suppressed due to low confidence (3)

template/pyproject.toml.jinja:27

  • [nitpick] This comment refers to a temporary pin for pyright, but the pin has been removed in the next line. Please update or remove this comment to avoid confusion.
    # Managed by upstream template

template/.devcontainer/install-ci-tooling.py.jinja:147

  • The {% endraw %} tag is on the same line as main(), introducing a stray curly brace and invalid syntax. Move {% endraw %} to its own line or adjust the raw block boundaries to produce valid Python code.
    main(){% endraw %}

.devcontainer/install-ci-tooling.py:121

  • The variable is_windows is used here but not defined in this scope. Consider defining is_windows = platform.system() == 'Windows' (or similar) before its use to avoid a NameError.
        if is_windows:

@ejfine ejfine merged commit d0f4449 into main Jun 18, 2025
8 checks passed
@ejfine ejfine deleted the publish-patch branch June 18, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants