Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances CI publishing by adding a fallback main PyPI registry and incorporates various upstream template updates, including version bumps and optional tooling installation.
- Add
--extra-index-urlfor main PyPI in the CI publish workflow - Bump dependency versions in templates and context files
- Introduce optional AWS SSM plugin installation in devcontainer tooling
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| template/pyproject.toml.jinja | Loosened pyright pin to >= and updated test tooling versions |
| template/.github/workflows/publish.yaml.jinja | Added --extra-index-url pointing to main PyPI |
| template/.github/dependabot.yml.jinja | Restricted Dependabot to minor updates only |
| template/.devcontainer/install-ci-tooling.py.jinja | Added Jinja logic and code for optional AWS SSM plugin installation |
| pyproject.toml | Bumped pytest, pytest-cov, and pyright versions |
| extensions/context.py | Updated context version values and added nginx_image_version |
| .github/dependabot.yml | Restricted Dependabot to minor updates only |
| .devcontainer/install-ci-tooling.py | Added optional AWS SSM plugin install logic and version bumps |
| .devcontainer/devcontainer.json | Updated devcontainer context hash |
| .copier-answers.yml | Updated copier-answers commit reference |
Comments suppressed due to low confidence (3)
template/pyproject.toml.jinja:27
- [nitpick] This comment refers to a temporary pin for
pyright, but the pin has been removed in the next line. Please update or remove this comment to avoid confusion.
# Managed by upstream template
template/.devcontainer/install-ci-tooling.py.jinja:147
- The
{% endraw %}tag is on the same line asmain(), introducing a stray curly brace and invalid syntax. Move{% endraw %}to its own line or adjust the raw block boundaries to produce valid Python code.
main(){% endraw %}
.devcontainer/install-ci-tooling.py:121
- The variable
is_windowsis used here but not defined in this scope. Consider definingis_windows = platform.system() == 'Windows'(or similar) before its use to avoid aNameError.
if is_windows:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
In CI, when installing from the pypi testing registry, project sub-dependencies weren't always there
How does this change address the issue?
Added the main PyPI registry as backup
What side effects does this change have?
None
How is this change tested?
Isn't
Other
Pulled in some upstream template updates