Skip to content

Fix publish job permissions #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejfine merged 2 commits into from
Aug 3, 2025
Merged

Fix publish job permissions #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e40321
tweak
ejfine Aug 3, 2025
c7ece3f
tag perm
ejfine Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions template/.github/workflows/publish.yaml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,18 +185,20 @@ jobs:
- name: Sleep to allow PyPI Index to update before proceeding to the next step
uses: juliangruber/sleep-action@{% endraw %}{{ gha_sleep }}{% raw %}
with:
time: 60s{% endraw %}{% endif %}{% raw %}
time: 90s{% endraw %}{% endif %}{% raw %}
- name: Install from staging registry
run: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://www.pypi.org/simple {% endraw %}{{ package_name | replace('_', '-') }}{% raw %}==${{ needs.get-values.outputs.package-version }}
- name: Display dependencies
run: pip list
- name: Confirm library can be imported successfully
run: python -c "import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}"
run: python -c "import sys; print(f'Python version {sys.version}'); import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}"

Comment on lines 193 to 195
Copy link

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Python version print statement adds debugging information but makes the command less focused. Consider separating the version check into a distinct step or making it conditional for cleaner separation of concerns.

Copilot uses AI. Check for mistakes.
create-tag:
name: Create the git tag
if: ${{ github.event.inputs.publish_to_primary }}
needs: [ install-from-staging ]
permissions:
contents: write # needed to push the tag
runs-on: {% endraw %}{{ gha_linux_runner }}{% raw %}
steps:
- name: Checkout code
Expand Down Expand Up @@ -278,10 +280,10 @@ jobs:
- name: Sleep to allow PyPI Index to update before proceeding to the next step
uses: juliangruber/sleep-action@{% endraw %}{{ gha_sleep }}{% raw %}
with:
time: 60s{% endraw %}{% endif %}{% raw %}
time: 90s{% endraw %}{% endif %}{% raw %}
- name: Install from primary registry
run: pip install {% endraw %}{{ package_name | replace('_', '-') }}{% raw %}==${{ needs.get-values.outputs.package-version }}
- name: Display dependencies
run: pip list
- name: Confirm library can be imported successfully
run: python -c "import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}"{% endraw %}
run: python -c "import sys; print(f'Python version {sys.version}'); import {% endraw %}{{ package_name | replace('-', '_') }}{% raw %}"{% endraw %}