failed with exit code 1120

[saracenaly]

Hello,

I can not install the library with pip it gives me "failed with exit code 1120" error code.

[billbrod]

Hmm, I am unable to reproduce your error, can you try installing pyrtools in a new virtual environment with python 3.7, 3.8, 3.9, or 3.10? If you continue to have problems, can you provide some more details on your system (what's your operating system, how did you install python and setup the virtual environment, what version of python, etc) and the steps you took?

[freshNfunky]

i had the same problem. It's obviously a Windows problem. Downloading pyrtools locally and applying this patch accordingly, fixed the problem: https://techoverflow.net/2022/01/23/how-to-fix-python-cffi-error-lnk2001-unresolved-external-symbol-pyinit__/
the fixed solution can be found in this forked repo and commit:
freshNfunky@d866ba3

[freshNfunky]

...Well it turned out, that patching the required method PyInit_wrapConv is not enough. This Function requires to return an object of the type: PyModuleDef. See: https://docs.python.org/3/extending/building.html
otherwise Python does not find any of the methods and fails with:

  File "C:\Users\xxx\AppData\Local\Programs\Python\Python38\lib\ctypes\__init__.py", line 387, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: function 'internal_reduce' not found

[billbrod]

Hey @freshNfunky , thanks for looking into this. With your fork, I'm able to install the package from pip without any errors, but on import, I get the following:

and then when I try to call the Laplacian pyramid (which uses the c code), I get:

But this is a different error than the one you mentioned above. Are you able to get a working install from your fork directly?

[NicWickman]

Thank you @freshNfunky for the first look at this. I have solved the issue for windows on my fork @ https://github.com/NicWickman/pyrtools

The solution to make methods visible through the compiled dll via _declspec(dllexport) in the new windows.c file and the header files.

I would submit a PR, but this won't compile on unix. A cross-platform solution using macros should be easy enough for someone who's familiar with them.

[billbrod]

Hi all, thanks for bringing this to our attention and for your proposing some solutions. With pull request #27, we now have Windows support. If you have try installing the newest version of pyrtools (either from source or pip, version 1.0.3), it should now work!

I'm going to close this issue, but if someone gets this issue again on Windows, please re-open it.