Skip to content

Eliminate javascript:void(0) and unchecked. Document mysterious handl… #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-adam merged 1 commit into from
Mar 18, 2024
Merged

Eliminate javascript:void(0) and unchecked. Document mysterious handl… #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mGAP/resources/views/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
}(jQuery, LABKEY));

</script>
<form class="auth-form" name="login" action="javascript:void(0)" method="post">
<form class="auth-form" name="login" method="post">
<div class="auth-header">Sign In</div>
<div class="labkey-error" id="errors"></div>
<div class="auth-form-body">
Expand All @@ -28,12 +28,13 @@
<div class="auth-header auth-item">Terms of Use</div>
<div class="toucontent auth-item termsOfUseContent"></div>
<div class="auth-item">
<input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item" unchecked>
<input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
<label for="approvedTermsOfUse">I agree to these terms</label>
</div>
</div>
<input type="hidden" name="termsOfUseType" id="termsOfUseType">
<div class="auth-item auth-credentials-submit">
<!-- Note: login.js attaches an authenticateUser() click event to elements with class "loginSubmitButton" -->
<input type="submit" tabindex="-1" class="loginSubmitButton"/>
<a tabindex="5" class="labkey-button primary signin-btn"><span>Sign In</span></a>
<span class="registrationSection">
Expand Down
5 changes: 3 additions & 2 deletions mcc/resources/views/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script type="text/javascript" nonce="<%=scriptNonce%>">

</script>
<form class="auth-form" name="login" action="javascript:void(0)" method="post">
<form class="auth-form" name="login" method="post">
<div class="auth-header">Sign In</div>
<div class="labkey-error" id="errors"></div>
<div class="auth-form-body">
Expand All @@ -16,12 +16,13 @@
<div class="auth-header auth-item">Terms of Use</div>
<div class="toucontent auth-item termsOfUseContent"></div>
<div class="auth-item">
<input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item" unchecked>
<input type="checkbox" tabindex="4" name="approvedTermsOfUse" id="approvedTermsOfUse" class="auth-item">
<label for="approvedTermsOfUse">I agree to these terms</label>
</div>
</div>
<input type="hidden" name="termsOfUseType" id="termsOfUseType">
<div class="auth-item auth-credentials-submit">
<!-- Note: login.js attaches an authenticateUser() click event to elements with class "loginSubmitButton" -->
<input type="submit" tabindex="-1" class="loginSubmitButton"/>
<a tabindex="5" class="labkey-button primary signin-btn"><span>Sign In</span></a>
<span class="registrationSection">
Expand Down