Skip to content

Conversation

@labkey-adam
Copy link

@labkey-adam labkey-adam commented Apr 14, 2024

Rationale

JAXB is no longer pulled in as a dependency

@labkey-adam labkey-adam requested a review from bbimber April 14, 2024 00:12
@labkey-adam
Copy link
Author

@bbimber my change should be consistent with previous, however, it looks like mcc doesn't use JAXB, so I'm tempted to delete the force plus the reference over in SequenceAnalysis. LMK what you think. (Any chance to get rid of references to the old version is helpful, IMO.)

@bbimber
Copy link
Collaborator

bbimber commented Apr 14, 2024

I will check it out. I think the force is purely to keep those two modules in sync, but it's been a long time. i dont believe they have very specific requirements around this

@labkey-adam
Copy link
Author

I will check it out. I think the force is purely to keep those two modules in sync, but it's been a long time. i dont believe they have very specific requirements around this

Sure, but there's no sign of JAXB being used by MCC. Examining its lib directory shows no JAXB jars. Removing the force and running showDiscrepancies results in no issues.

@bbimber
Copy link
Collaborator

bbimber commented Apr 14, 2024

OK, if you have looked at this and it passes w/o the exclude, then I imagine it's fine. I am pretty sure I added this exclude a long time ago to resolve something like a gradle discrepancy issue. If that's gone without this, it's probably better to drop it.

@labkey-adam labkey-adam changed the title Use old JAXB property Eliminate unnecessary force Apr 15, 2024
@labkey-adam labkey-adam merged commit 59054c9 into develop Apr 16, 2024
@labkey-adam labkey-adam deleted the fb_jaxb branch April 16, 2024 03:19
bbimber added a commit that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants