Skip to content

Declare api and implementation dependencies to align with code usages #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 4 commits into from
Sep 22, 2020
Merged

Declare api and implementation dependencies to align with code usages #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a709448
Remove commons-math3 from :server:modules:platform:api
labkey-susanh Sep 7, 2020
7e767aa
Add external dependencies that had been leaking out of other dependen…
labkey-susanh Sep 7, 2020
3d76aa0
Merge remote-tracking branch 'origin/develop' into fb_dependencyHealth
labkey-susanh Sep 17, 2020
d5dd588
Align jars.txt with dependency declarations
labkey-susanh Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions elispot_assay/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import org.labkey.gradle.util.BuildUtils;

dependencies {
external "org.apache.commons:commons-math3:${commonsMath3Version}"
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:LabDevKitModules:laboratory", depProjectConfig: "apiJarFile")
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:LabDevKitModules:LDK", depProjectConfig: "apiJarFile")

Expand Down
4 changes: 4 additions & 0 deletions elispot_assay/resources/credits/jars.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{table}
Filename|Component|Version|Source|License|LabKey Dev|Purpose
commons-math3-3.6.1.jar|Commons Math|3.6.1|{link:Apache|http://commons.apache.org/math/}|{link:Apache 2.0|http://www.apache.org/licenses/LICENSE-2.0}||Lightweight, self-contained mathematics and statistics components
{table}
2 changes: 2 additions & 0 deletions variantdb/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import org.labkey.gradle.util.BuildUtils;

dependencies {
implementation "com.github.samtools:htsjdk:${htsjdkVersion}"
external "commons-net:commons-net:${commonsNetVersion}"
external "org.apache.commons:commons-math3:${commonsMath3Version}"
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:LabDevKitModules:laboratory", depProjectConfig: "apiJarFile")
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:LabDevKitModules:LDK", depProjectConfig: "apiJarFile")
BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:DiscvrLabKeyModules:SequenceAnalysis", depProjectConfig: "apiJarFile")
Expand Down
5 changes: 5 additions & 0 deletions variantdb/resources/credits/jars.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{table}
Filename|Component|Version|Source|License|Purpose
commons-math3-3.6.1.jar|Commons Math|3.6.1|{link:Apache|http://commons.apache.org/math/}|{link:Apache 2.0|http://www.apache.org/licenses/LICENSE-2.0}|Lightweight, self-contained mathematics and statistics components
commons-net-3.5.jar|Commons Net|3.3|{link:Apache|http://jakarta.apache.org/commons/net/}|{link:Apache 2.0|http://www.apache.org/licenses/LICENSE-2.0}|FTPClient used to retrieve resources from other servers (e.g., GO annotations)
{table}