Add missing dependencies on opencsv and httpmime #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing out of the labkey-client-api. Since both of these dependencies are included in the api module transitively, we compromise a bit and do not include them in the jars.txt for each individual module.
labkey-tchad
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
With version 1.4.0 of the labkey-client-api, we will convert the dependencies on opencsv and httpmime from api dependencies to implementation dependencies since they are not actually a part of the api for this jar file. Since both of these dependencies are included in the api module transitively, we compromise a bit and do not include them in the
jars.txtfor each individual module.Related Pull Requests
Changes