Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jun 3, 2021

Generated automatically.

Approve all matching PRs simultaneously.

Approval will trigger automatic merge.

@bbimber bbimber merged commit e604bfe into release21.3-SNAPSHOT Jun 4, 2021
@bbimber bbimber deleted the 21.3_fb_merge_20.11.Merge branch June 4, 2021 16:37
@github-actions
Copy link
Author

github-actions bot commented Jun 4, 2021

ERROR Automatic merge failed!

@bbimber
Copy link
Collaborator

bbimber commented Jun 4, 2021

@labkey-tchad thoughts on the failure?

@github-actions
Copy link
Author

github-actions bot commented Jun 4, 2021

ERROR Automatic merge failed!

@labkey-tchad
Copy link
Member

@labkey-tchad thoughts on the failure?

The bot is trying to automatically merge the PR but it fails because you already did the merge manually

@bbimber
Copy link
Collaborator

bbimber commented Jun 4, 2021

OK, sorry. Next time i get an approval should I just approve and leave it alone then?

@labkey-tchad
Copy link
Member

Generally, yeah; not a big deal though.
I think our process is a little unusual in that reviewers are rarely responsible for merging PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants