Merge discvr 20.3 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch ContainerManager.Property.Policy -> Modules
labkey-jeckels
approved these changes
Jul 10, 2020
Collaborator
Author
|
@labkey-jeckels OK, I made the change from Policy->Modules. I apparently still dont quite get the release/branching structure. I thought the progression was the opposite: changes are made in releaseXX.XX, and periodically this is tagged as release-SNAPSHOTXX.XX. This makes releaseXX.XX slightly less stable than SHAPSHOT. Do I have this backwards then? |
|
Yup, it's the opposite. The SNAPSHOT version is the unstable work-in-progress. It's OK to have multiple builds of a SNAPSHOT version (and Artifactory will keep checking if there's a newer one), but you should only have a single version of a non-SNAPSHOT build from the release branch, like 20.7.0 |
bbimber
added a commit
that referenced
this pull request
Dec 13, 2024
Convert species table to be container-scoped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the earlier PR against devel.
@labkey-jeckels in the other thread you said LaboratoryContainerListener should now be listening to the newly added Modules property instead of Policy. What am I missing? I dont see this in the enum.
https://github.com/LabKey/platform/blob/release20.7/api/src/org/labkey/api/data/ContainerManager.java