Skip to content

Conversation

@labkey-jeckels
Copy link

Rationale

In LabKey/platform#2754 I switched to using the current TableInfo's schema and table name when wiring up the button handler. However, in some cases, we've been explicitly configured to point at a different table instead (like a query that wants to offer "edit" capabilities). So, we need to support both usage patterns.

Related Pull Requests

Changes

  • Move ShowEditUIButton from platform repo
  • Use button configuration when it's been pointed at a specific schema/query, and the TableInfo's schema/query otherwise

@labkey-jeckels labkey-jeckels requested a review from cnathe December 7, 2021 00:54
@bbimber
Copy link
Collaborator

bbimber commented Dec 7, 2021

@labkey-jeckels It's been a long time since i've thought about this, but do any newer changes in the build allow us to move those other LDK classes from platform into LDK itself? there used to be issues about the API module from one depending on another, but I thought maybe that was resolved at some point.

@labkey-jeckels
Copy link
Author

@bbimber I don't think there have been any changes to allow one module's API classes to reference another module's API classes. However, in this case it's just implementations that need to reference ShowEditUIButton so I got lucky with an easy refactor/move

@labkey-jeckels labkey-jeckels merged commit 376bdaf into release21.7-SNAPSHOT Dec 10, 2021
@labkey-jeckels labkey-jeckels deleted the 21.7_fb_ticket44386_editableQueries branch December 10, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants