Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Remove immutable default ButtonBars, unscoped to a controller. Update the small number of places I could find that rely on those default button, mainly very old code in experiment, user, and mothership UI.

Remove display mode from DisplayElement. Only configure the buttons and columns that are desired for the type of view that is being used (insert, update, grid, details, etc)

…n when table has XML-customized buttons

Remove immutable default ButtonBars, unscoped to a controller. Update the small number of places I could find that rely on those default button, mainly very old code in experiment, user, and mothership UI.

Remove display mode from DisplayElement. Only configure the buttons and columns that are desired for the type of view that is being used (insert, update, grid, details, etc)
@labkey-jeckels
Copy link
Contributor Author

Since there was a minor SVN change (committed there this morning with revision 63443) I did a remote run. Found and fixed one problem in the BVTs. DailyC, arbitrarily chosen, seemed OK as well with one perhaps intermittent failure.

Thus, there may be some small issues, but I don't expect widespread problems.

Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@labkey-jeckels labkey-jeckels merged commit c0f3835 into develop Apr 22, 2019
@labkey-jeckels labkey-jeckels deleted the fb_37278 branch April 22, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants