Skip to content

Prevent NPEs in mascot client due to undefined server URL #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
labkey-tchad merged 1 commit into from
May 1, 2019
Merged

Prevent NPEs in mascot client due to undefined server URL #19

labkey-tchad merged 1 commit into from
May 1, 2019

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Apr 30, 2019

Hitting the blank MascotTestAction throws a 500 like:

java.lang.NullPointerException
       at org.labkey.ms2.pipeline.mascot.MascotClientImpl.findWorkableSettings(MascotClientImpl.java:230)
       at org.labkey.ms2.MS2Controller$MascotTestAction.getView(MS2Controller.java:4745)
       at org.labkey.ms2.MS2Controller$MascotTestAction.getView(MS2Controller.java:4736)

labkey-jeckels
labkey-jeckels approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of passing around empty strings like this, especially constructing URL objects from them, but this seems to work OK here. And the UI prevents you from testing the configuration, so it's really just a crawler issue.

Approved.

@labkey-tchad labkey-tchad merged commit 89edcdc into develop May 1, 2019
@labkey-tchad labkey-tchad deleted the fb_crawler_mascot_test branch May 1, 2019 23:33
labkey-adam added a commit that referenced this pull request May 6, 2019
@labkey-adam
Merge from develop (#20)
af98030 
* Prevent NPEs in mascot client due to undefined server URL (#19)

* Make NAb actions 404 when a non-NAb runId is specified (#18)
labkey-tchad added a commit that referenced this pull request Feb 24, 2025
@labkey-tchad
Remove WebDriverWrapper.setDropZone (#19)
13cba1e 
Add some delays to prevent saveRun failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@labkey-tchad @labkey-jeckels