Ticket 42744: Grid view menu selection items clipped in task details #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi Josh. I reviewed your code changes, and the menu items are no longer truncated based on testing your code on my Can you please move your code into Team City as a feature branch build so that i can have my Prime users a chance to review the code changes before moving it into a production build. Thanks, |
Contributor
Author
|
Glad to hear that the approach shows promise. There's already a feature branch in GitHub, but it's in the ehrModules repository. TeamCity is only automatically triggering installer builds when it sees changes in onprcEhrModules. Thus, I manually triggered one. It's now running: |
labkey-martyp
approved these changes
Apr 14, 2021
labkey-tchad
pushed a commit
that referenced
this pull request
Feb 24, 2025
* - Added database function to return a list of fully expanded superpackages - fixed JSONObject getter error - updated module to 23.005 * - removed file with bad encoding * - Added static reference for fGetAllSuperPkgs in SNDSchema.java - re-added snd-23.004-23.005.sql
labkey-tchad
pushed a commit
that referenced
this pull request
Feb 24, 2025
* Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changed subpackage query * Schema update and fix (#144) * Fixed defaultValue data type in PackageAttributeTable.java * - Added sortOrder column to Java class, SQL, and XML - Added sortOrder column to SNDTest.java * - Added additional exception handling in parseEventData() * Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changes * added subpackages to narratives * added sorting to subpackages * New superPackages database function (#148) * - Added database function to return a list of fully expanded superpackages - fixed JSONObject getter error - updated module to 23.005 * - removed file with bad encoding * - Added static reference for fGetAllSuperPkgs in SNDSchema.java - re-added snd-23.004-23.005.sql * Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changes * added subpackages to narratives * added sorting to subpackages * Increased default value of EventDataId in SNDSequencer (#131) * refactored narrative cache code for optimization * added styling * cached childSuperPackages * cached childSuperPackages * fixed failing event test * reverted formatting * reverted formatting * - Changed accessor methods for JSON data (attribute data) --------- Co-authored-by: Terry J Hawkins <thawkins@txbiomed.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
ExtJS panels can clip popup menus in QueryWebParts, so it's easier to just use "raw" QueryWebParts
Changes