Prevent shared EHR properties from moving out of /Shared #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties in datasets ends up reparenting shared property descriptors from /Shared into the EHR folder
labkey-martyp
approved these changes
Apr 18, 2021
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
Glad you found a repro. This fix looks good. Looks like it only reparents the newly added PDs to shared container?
Contributor
Author
|
Yes, all the other properties that are dataset-specific should continue to live in the EHR folder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Fix long-standing bug where running the EHR's check for missing properties in datasets ends up reparenting shared property descriptors from /Shared into the EHR folder
Changes