Update test to use "enddate" column name instead of bogus "end" field #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e" value, but the test has always been using the incorrectly named "end" field
| } | ||
|
|
||
| // Then try again with the problem corrected | ||
| protocolCountsRow.put("end", prepareDate(new Date(), 370, 0)); |
Contributor
There was a problem hiding this comment.
after reading the rationale I am confused if column name here should be "enddate" now?
Contributor
Author
There was a problem hiding this comment.
Yes, it should. I pushed and update and queued a test run:
labkey-ankurj
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A trigger script recently got stricter about requiring an "enddate" value. That pointed out that the test has long been using the invalid "end" name, which was ignored
Related Pull Requests
Changes