Add support for the modules to opt in to navigate to data entry forms when clicking edit links in animal history reporting #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e user to data entry form
labkey-ankurj
commented
Aug 26, 2021
|
|
||
| DetailsURL updateUrl = DetailsURL.fromString(detailsStr); | ||
| DetailsURL updateUrl; | ||
| if (EHRServiceImpl.get().isUseFormEditUI(getContainer()) && null != ti.getColumn("taskid")) |
Contributor
Author
There was a problem hiding this comment.
@labkey-jeckels I think this will be useless when there is no value for task ids.
Contributor
There was a problem hiding this comment.
Yes, agreed. Checking for the presence of that column is a good idea.
labkey-jeckels
approved these changes
Aug 26, 2021
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
See TNPRC PR for a rename suggestion, but otherwise looks good.
|
|
||
| DetailsURL updateUrl = DetailsURL.fromString(detailsStr); | ||
| DetailsURL updateUrl; | ||
| if (EHRServiceImpl.get().isUseFormEditUI(getContainer()) && null != ti.getColumn("taskid")) |
Contributor
There was a problem hiding this comment.
Yes, agreed. Checking for the presence of that column is a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds support for the modules to opt in to navigate to data entry forms when clicking edit links in animal history reporting through
EHRService.addModuleRequiringFormEditUI()Related Pull Requests