Skip to content

Conversation

@Ohsudev
Copy link
Collaborator

@Ohsudev Ohsudev commented Sep 8, 2021

Rationale

Related Pull Requests

Changes

Re-created an older feature branch version of the Compliance Employee Input screen.

Copy link
Collaborator

@kollil kollil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.


ALTER TABLE ehr_compliancedb.Employees add objectid entityid;

ALTER TABLE ehr_complianEHR_ComplianceDB-12.42-12.43.sqledb.RequirementsPerCategory add objectid entityid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a misplaced copy/paste

@Ohsudev
Copy link
Collaborator Author

Ohsudev commented Sep 9, 2021 via email

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade script is now running on Postgres. Now that it's getting further, there are mismatches between the actual DB tables and the ehr_compliancedb.xml file that are causing problems.

On TeamCity, it's showing this:

Errors in schema ehr_compliancedb.xml. Click here for an XML doc with fixes.
ERROR: Table "requirementspercategory", column "objectid" missing from XML.
ERROR: Table "requirementspercategory", column "trackingflag" missing from XML.
ERROR: Table "completiondates", column "taskid" found in XML but not in database.

Separately, I don't think the QCState column should be added to the XML. It hasn't been added to the real table, has it?

@Ohsudev
Copy link
Collaborator Author

Ohsudev commented Oct 4, 2021

No longer needed.

@Ohsudev Ohsudev closed this Oct 4, 2021
@Ohsudev Ohsudev deleted the 20.11_fb_EmployeeUnitsEntry branch October 8, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants