-
Notifications
You must be signed in to change notification settings - Fork 3
Re-created this new feature branch for Compliance input screens #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kollil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
|
|
||
| ALTER TABLE ehr_compliancedb.Employees add objectid entityid; | ||
|
|
||
| ALTER TABLE ehr_complianEHR_ComplianceDB-12.42-12.43.sqledb.RequirementsPerCategory add objectid entityid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a misplaced copy/paste
|
Thanks, Josh. I will make the necessary corrections. I’m just continuing to have jumping keystrokes issues with my work
computer, unable to predict sometimes where the text item will land.
From: Josh Eckels ***@***.***>
Sent: Wednesday, September 8, 2021 6:26 PM
To: LabKey/ehrModules ***@***.***>
Cc: Raymond Blasa ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [LabKey/ehrModules] Re-created this new feature branch for Compliance input screens (#232)
@labkey-jeckels requested changes on this pull request.
________________________________
In EHR_ComplianceDB/resources/Thanschemas/dbscripts/postgresql/EHR_ComplianceDB-12.40-12.41.sql<#232 (comment)>:
@@ -0,0 +1,9 @@
+ALTER TABLE ehr_compliancedb.Employees add taskid entityid;
+
+ALTER TABLE ehr_compliancedb.RequirementsPerCategory add taskid entityid;
+
+ALTER TABLE ehr_compliancedb.Employees add objectid entityid;
+
+ALTER TABLE ehr_complianEHR_ComplianceDB-12.42-12.43.sqledb.RequirementsPerCategory add objectid entityid;
Looks like a misplaced copy/paste
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#232 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASHU2YG274TS36ERF4PDV7TUBAEJLANCNFSM5DV3RYDA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
labkey-jeckels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade script is now running on Postgres. Now that it's getting further, there are mismatches between the actual DB tables and the ehr_compliancedb.xml file that are causing problems.
On TeamCity, it's showing this:
ERROR: Table "requirementspercategory", column "objectid" missing from XML.
ERROR: Table "requirementspercategory", column "trackingflag" missing from XML.
ERROR: Table "completiondates", column "taskid" found in XML but not in database.
Separately, I don't think the QCState column should be added to the XML. It hasn't been added to the real table, has it?
…d missing columns into xml file.
…d missing columns into xml file.
|
No longer needed. |
Rationale
Related Pull Requests
Changes
Re-created an older feature branch version of the Compliance Employee Input screen.