Skip to content

Conversation

@labkey-jeckels
Copy link
Contributor

Rationale

ONPRC has added a query that depends on geneticscore. It's easier to fake it up via a linked schema than to fully configure that module for testing purposes

Related Pull Requests

Changes

  • Set module property, configure linked schema

@bbimber
Copy link
Collaborator

bbimber commented Nov 7, 2021

@labkey-jeckels hi josh - what is new in terms of queries? consuming MHC data in the ONPRC EHR container via a linked query is fairly old. is this a chance in actual functionality, or something to make tests work differently?

@labkey-jeckels
Copy link
Contributor Author

See the new SQL query in this PR:

https://github.com/LabKey/onprcEHRModules/pull/283/files

Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you know what you're doing here...

@labkey-jeckels labkey-jeckels merged commit 4323f7b into release21.7-SNAPSHOT Nov 8, 2021
@labkey-jeckels labkey-jeckels deleted the 21.7_fb_ModuleContainerforMHC branch November 8, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants