Adjustments to blood summary plot #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
This looks great. As discussed, a couple changes for the y axis,
- Handle the case where available blood goes below zero. Should just need to adjust the range and the plot will automatically shade that in red. Could consider extending y axis below zero if getting close to zero. Like subtracting 10% of max allowable from bottom is negative, then that is the y axis lower range, otherwise it's zero.
- Maybe just adding 10% instead of 10mL to the top range of the y axis.
labkey-martyp
approved these changes
Nov 24, 2024
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
@csebranek This looks good. Please let me know when you're ready to merge this in. I have another PR that will need to be merged in as well.
Collaborator
|
@csebranek and @labkey-martyp: out of curiosity, why does EHR need a separate server-side action to get the blood data? Why doesnt select rows with very minor client-side reformatting accomplish the same thing? |
Contributor
|
@bbimber Yeah I don't see anything that couldn't be done with select rows. I don't remember the reason we gave it it's own action. @csebranek something we can consider if there are further modifications here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Adding a legend for readability, and starting the y-axis at zero to more accurately show if an animal is almost out of blood.
Related Pull Requests
Changes