-
Notifications
You must be signed in to change notification settings - Fork 3
Add properties for updating configurations of the node plugin to use a single version of binaries; remove yarn configurations
#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node plugin to use a single version of binaries; remove yarn configurationsnode plugin to use a single version of binaries; remove yarn configurations
This was referenced Dec 17, 2024
labkey-adam
approved these changes
Dec 17, 2024
labkey-tchad
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Our default configuration for modules using npm is to have each module act independently, using its own downloaded version of node and npm. We have a good number of modules using npm, so this leads to our having lots of redundant copies of these binaries in play while developing. We recently removed support for standalone module building, so there is no real compelling case for the current default configuration (except that it is the default for the third-party plugin and generally what is recommended when using a non-default value has issues). We've also recently seen builds failing when trying to download the binaries for some of the modules that are built later in the build process. Though we don't know that it is because of our downloading the binaries multiple times, we also don't know that that isn't the cause.
This PR adds two optional properties (
useServerNodeanduseOwnNode) to make it possible to experiment with a common configuration for that downloadednodeandnpmbinaries.nodedownloads its own copy ofnodeandnpmin the default.gradledirectory for the moduleuseServerNodeis defined, the download directory is specified as<enlistment root>/.nodeuseServerNodeis defined, a module that definesuseOwnNodewill revert to the default behaviorIf any modules need to be differently configured (with a different version of node or a different working directory), they can still do so by setting up their own configuration of the
npmextension. This is an incubating feature because having all modules use the server binaries doesn't seem to always work for reasons that I cannot discern and I need to move on with other things at the moment.We also remove the configurations related to
yarntasks since we do not anticipate having any projects usingyarn.Related Pull Requests
Changes
dependencyProjectdeployModuletaskuseServerNodeanduseOwnNodefor configuringNpmRun(incubating)