Declare api and implementation dependencies to better align with code usages #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Sep 21, 2020
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Just wondering about the version
labkey-client-api/CHANGELOG.md
Outdated
| * Fix pre-population of session ID and CSRF token in Connection | ||
| * Identify target server with a `URI` instead of a `String` | ||
| * Add support for Log4J 2 | ||
| * Add some missing dependency declarations |
Member
There was a problem hiding this comment.
Should this release be 1.3.2, maybe 1.4?
This was referenced Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
It is generally best practice to explicitly declare dependencies that are used in your code rather than relying on transitive dependencies to supply them for you if for no other reason than it documents what is in use. Though in reality the risk of these transitive dependencies disappearing is low and would usually be easily noticed, the declaration of proper api dependencies will assure that our published pom files are accurate and others will not have to separately declare some dependencies that we rely on when using our jar files.
Related Pull Requests
Changes