Issue 53463: Add query-saveRows.api endpoint wrapper to Java client API #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
| Delete | ||
| } | ||
|
|
||
| public static class Command |
Contributor
There was a problem hiding this comment.
Largely a duplicate of SaveRowsCommand, but for the CommandType. Even if we decide not to rebrand SaveRowsCommand, I think making that class a shell that derives from CommandBase that could then also be used here might be a good idea.
Contributor
Author
There was a problem hiding this comment.
As discussed, not really overlap in behavior since this is not a command like a post command or a get command (in labkey-api-java parlance). Added comment above class explaining this.
This was referenced Jul 17, 2025
This was referenced Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses Issue 53463 by adding an endpoint wrapper
SaveRowsApiCommandfor thequery-saveRows.apiendpoint. Integration test coverage added in related PR.Related Pull Requests
Changes
SaveRowsApiCommandto prepare and execute requests againstquery-saveRows.apiendpoint.SaveRowsApiResponsethat wraps endpoint response.includeEmptyPermGroupsto GetGroupPermsCommand