Skip to content

Multi value text choices #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
XingY wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Multi value text choices #1923

XingY wants to merge 15 commits into from
+409 −211

Conversation

@XingY
Copy link
Contributor

@XingY XingY commented Jan 12, 2026 •
edited
Loading

Rationale

This PR enables "Multi Choice" data type in domain designer and supports editing/sorting multi values in the app.

Related Pull Requests

Changes

  • Added new MULTI_CHOICE_RANGE_URI for defining MVTC fields and updated utils to check against data type
  • renamed joinValues prop for SelectInput to skipJoinValues to align with its actual usage
  • Modified FilterFacetedSelector and QueryFilterPanel to handle array value selecting for MVTC

This was referenced Jan 12, 2026
Open
Open
@XingY XingY requested a review from Copilot January 13, 2026 21:47
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@XingY XingY requested a review from Copilot January 14, 2026 19:40

This comment was marked as resolved.

Sign in to view

@XingY XingY requested a review from labkey-alan January 14, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@labkey-alan labkey-alan Awaiting requested review from labkey-alan

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XingY