Disallow null Id values in onprc_ehr.AvailableBloodVolume, give it a PK #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jonesgaohsuand @kollil can you validate this change for us? I think it will help prevent problems and lets us add the test coverage. There's a chance it would interfere with how the data is being populated. If, for example, it loads all new rows and then deletes all of the old rows, it would violate the PK constraint, and the sequence would need to be reversed (delete the existing rows first, then load the replacement data) |
labkey-sweta
approved these changes
Mar 25, 2021
…dVolume # Conflicts: # onprc_ehr/resources/schemas/dbscripts/sqlserver/onprc_ehr-20.905-20.906.sql # onprc_ehr/src/org/labkey/onprc_ehr/ONPRC_EHRModule.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
While adding automated test coverage for the ONPRC blood volume validation code, we discovered that having duplicate rows for a given animal in onprc_ehr.AvailableBloodVolume will cause errors when doing the validation. It also lacks a PK, making it hard for the tests to interact with it to populate testing data
Changes